[U-Boot] [PATCH] config.mk:Update DBGFLAGS with dwarf information

[U-Boot] [PATCH] config.mk:Update DBGFLAGS with dwarf information

[Prabhakar Kushwaha]

Built u-boot elf file does not contain any dwarf informations by default. This
information is required for debugging.

Add dwarf ver 2 flag in DBGFLAGS.

Signed-off-by: Radu Lazarescu <radu.lazarescu@freescale.com>
Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com>
---
 Applies on http://git.denx.de/u-boot.git branch master

 config.mk |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/config.mk b/config.mk
index ddaa477..11bc20d 100644
--- a/config.mk
+++ b/config.mk
@@ -178,7 +178,7 @@ endif
 # who are porting old code to latest mainline but not updating $(AR).
 ARFLAGS = $(error update your Makefile to use cmd_link_o_target and not AR)
 RELFLAGS= $(PLATFORM_RELFLAGS)
-DBGFLAGS= -g # -DDEBUG
+DBGFLAGS= -g -gdwarf-2 # -DDEBUG
 OPTFLAGS= -Os #-fomit-frame-pointer
 
 OBJCFLAGS += --gap-fill=0xff
-- 
1.7.5.4

[U-Boot] [PATCH] config.mk:Update DBGFLAGS with dwarf information

[Prabhakar Kushwaha]

Hi,

This patch has review-pending from  a very long time.

I request the "mailing-list" to review this patch.

Regards,
Prabhakar

On Wednesday 15 February 2012 02:25 PM, Prabhakar Kushwaha wrote:
> Built u-boot elf file does not contain any dwarf informations by default. This
> information is required for debugging.
>
> Add dwarf ver 2 flag in DBGFLAGS.
>
> Signed-off-by: Radu Lazarescu<radu.lazarescu@freescale.com>
> Signed-off-by: Prabhakar Kushwaha<prabhakar@freescale.com>
> ---
>   Applies on http://git.denx.de/u-boot.git branch master
>
>   config.mk |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/config.mk b/config.mk
> index ddaa477..11bc20d 100644
> --- a/config.mk
> +++ b/config.mk
> @@ -178,7 +178,7 @@ endif
>   # who are porting old code to latest mainline but not updating $(AR).
>   ARFLAGS = $(error update your Makefile to use cmd_link_o_target and not AR)
>   RELFLAGS= $(PLATFORM_RELFLAGS)
> -DBGFLAGS= -g # -DDEBUG
> +DBGFLAGS= -g -gdwarf-2 # -DDEBUG
>   OPTFLAGS= -Os #-fomit-frame-pointer
>
>   OBJCFLAGS += --gap-fill=0xff

[U-Boot] [PATCH] config.mk:Update DBGFLAGS with dwarf information

[Mike Frysinger]

On Wednesday 15 February 2012 03:55:31 Prabhakar Kushwaha wrote:
> Built u-boot elf file does not contain any dwarf informations by default.
> This information is required for debugging.

no real information here as to what is going wrong.  the -g flag provides debug 
information and many people (myself included) have found this sufficient.

please describe your actual problem in detail and how this actually fixes 
things for you.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120514/228e6106/attachment.pgp>

[U-Boot] [PATCH] config.mk:Update DBGFLAGS with dwarf information

[Prabhakar Kushwaha]

Hi Wolfgang,

This patch has been pending for a very long time.  No review comments 
has been provided.

Can you please review/accept this patch.


Regards,
Prabhakar


On 04/25/2012 09:41 AM, Prabhakar Kushwaha wrote:
> Hi,
>
> This patch has review-pending from  a very long time.
>
> I request the "mailing-list" to review this patch.
>
> Regards,
> Prabhakar
>
> On Wednesday 15 February 2012 02:25 PM, Prabhakar Kushwaha wrote:
>> Built u-boot elf file does not contain any dwarf informations by 
>> default. This
>> information is required for debugging.
>>
>> Add dwarf ver 2 flag in DBGFLAGS.
>>
>> Signed-off-by: Radu Lazarescu<radu.lazarescu@freescale.com>
>> Signed-off-by: Prabhakar Kushwaha<prabhakar@freescale.com>
>> ---
>>   Applies on http://git.denx.de/u-boot.git branch master
>>
>>   config.mk |    2 +-
>>   1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/config.mk b/config.mk
>> index ddaa477..11bc20d 100644
>> --- a/config.mk
>> +++ b/config.mk
>> @@ -178,7 +178,7 @@ endif
>>   # who are porting old code to latest mainline but not updating $(AR).
>>   ARFLAGS = $(error update your Makefile to use cmd_link_o_target and 
>> not AR)
>>   RELFLAGS= $(PLATFORM_RELFLAGS)
>> -DBGFLAGS= -g # -DDEBUG
>> +DBGFLAGS= -g -gdwarf-2 # -DDEBUG
>>   OPTFLAGS= -Os #-fomit-frame-pointer
>>
>>   OBJCFLAGS += --gap-fill=0xff
>
>
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>

[U-Boot] [PATCH] config.mk:Update DBGFLAGS with dwarf information

[Graeme Russ]

Hi Prabhakar,

On Thu, May 24, 2012 at 2:43 PM, Prabhakar Kushwaha
<prabhakar@freescale.com> wrote:
> Hi Wolfgang,
>
> This patch has been pending for a very long time. ?No review comments has
> been provided.

Mike Frysinger posted a comment on May 14, 2012:

[quote]
no real information here as to what is going wrong.  the -g flag provides debug
information and many people (myself included) have found this sufficient.

please describe your actual problem in detail and how this actually fixes
things for you.
-mike

[/quote]

Regards,

Graeme

[U-Boot] [PATCH] config.mk:Update DBGFLAGS with dwarf information

[Prabhakar Kushwaha]

Hi,

Sorry for the delayed response. I somehow missed this  :(

On 06/19/2012 10:29 AM, Prabhakar Kushwaha wrote:
> Hi Prabhakar,
>
> On Thu, May 24, 2012 at 2:43 PM, Prabhakar Kushwaha
> <prabhakar@freescale.com> wrote:
> > Hi Wolfgang,
> >
> > This patch has been pending for a very long time.  No review 
> comments has
> > been provided.
>
> Mike Frysinger posted a comment on May 14, 2012:
>
> [quote]
> no real information here as to what is going wrong.  the -g flag 
> provides debug
> information and many people (myself included) have found this sufficient.
>
> please describe your actual problem in detail and how this actually fixes
> things for you.
> -mike
>
>

I agree with Mike's reply i.e. -g flag provides sufficient debug 
information.
But some debugger requires debug information in specific format i.e. 
-gdwarf-2
For example Freescale CodeWarrior Debugger


Regards,
Prabhakar

>
>>
>>
>> On 04/25/2012 09:41 AM, Prabhakar Kushwaha wrote:
>>> Hi,
>>>
>>> This patch has review-pending from  a very long time.
>>>
>>> I request the "mailing-list" to review this patch.
>>>
>>> Regards,
>>> Prabhakar
>>>
>>> On Wednesday 15 February 2012 02:25 PM, Prabhakar Kushwaha wrote:
>>>> Built u-boot elf file does not contain any dwarf informations by 
>>>> default. This
>>>> information is required for debugging.
>>>>
>>>> Add dwarf ver 2 flag in DBGFLAGS.
>>>>
>>>> Signed-off-by: Radu Lazarescu<radu.lazarescu@freescale.com>
>>>> Signed-off-by: Prabhakar Kushwaha<prabhakar@freescale.com>
>>>> ---
>>>>   Applies on http://git.denx.de/u-boot.git branch master
>>>>
>>>>   config.mk |    2 +-
>>>>   1 files changed, 1 insertions(+), 1 deletions(-)
>>>>
>>>> diff --git a/config.mk b/config.mk
>>>> index ddaa477..11bc20d 100644
>>>> --- a/config.mk
>>>> +++ b/config.mk
>>>> @@ -178,7 +178,7 @@ endif
>>>>   # who are porting old code to latest mainline but not updating 
>>>> $(AR).
>>>>   ARFLAGS = $(error update your Makefile to use cmd_link_o_target 
>>>> and not AR)
>>>>   RELFLAGS= $(PLATFORM_RELFLAGS)
>>>> -DBGFLAGS= -g # -DDEBUG
>>>> +DBGFLAGS= -g -gdwarf-2 # -DDEBUG
>>>>   OPTFLAGS= -Os #-fomit-frame-pointer
>>>>
>>>>   OBJCFLAGS += --gap-fill=0xff
>>>
>>>
>>>
>>> _______________________________________________
>>> U-Boot mailing list
>>> U-Boot at lists.denx.de
>>> http://lists.denx.de/mailman/listinfo/u-boot
>>>
>>
>>
>>
>> _______________________________________________
>> U-Boot mailing list
>> U-Boot at lists.denx.de
>> http://lists.denx.de/mailman/listinfo/u-boot
>>
>
>

[U-Boot] [PATCH] config.mk:Update DBGFLAGS with dwarf information

[Prabhakar Kushwaha]

Hi Mike/Graeme.

Please help me in closing review related comments on this patch.

Thanks,
Prabhakar

On 06/19/2012 10:38 AM, Prabhakar Kushwaha wrote:
>
> Hi,
>
> Sorry for the delayed response. I somehow missed this  :(
>
> On 06/19/2012 10:29 AM, Prabhakar Kushwaha wrote:
>> Hi Prabhakar,
>>
>> On Thu, May 24, 2012 at 2:43 PM, Prabhakar Kushwaha
>> <prabhakar@freescale.com> wrote:
>> > Hi Wolfgang,
>> >
>> > This patch has been pending for a very long time.  No review 
>> comments has
>> > been provided.
>>
>> Mike Frysinger posted a comment on May 14, 2012:
>>
>> [quote]
>> no real information here as to what is going wrong.  the -g flag 
>> provides debug
>> information and many people (myself included) have found this 
>> sufficient.
>>
>> please describe your actual problem in detail and how this actually 
>> fixes
>> things for you.
>> -mike
>>
>>
>
> I agree with Mike's reply i.e. -g flag provides sufficient debug 
> information.
> But some debugger requires debug information in specific format i.e. 
> -gdwarf-2
> For example Freescale CodeWarrior Debugger
>
>
> Regards,
> Prabhakar
>
>>
>>>
>>>
>>> On 04/25/2012 09:41 AM, Prabhakar Kushwaha wrote:
>>>> Hi,
>>>>
>>>> This patch has review-pending from  a very long time.
>>>>
>>>> I request the "mailing-list" to review this patch.
>>>>
>>>> Regards,
>>>> Prabhakar
>>>>
>>>> On Wednesday 15 February 2012 02:25 PM, Prabhakar Kushwaha wrote:
>>>>> Built u-boot elf file does not contain any dwarf informations by 
>>>>> default. This
>>>>> information is required for debugging.
>>>>>
>>>>> Add dwarf ver 2 flag in DBGFLAGS.
>>>>>
>>>>> Signed-off-by: Radu Lazarescu<radu.lazarescu@freescale.com>
>>>>> Signed-off-by: Prabhakar Kushwaha<prabhakar@freescale.com>
>>>>> ---
>>>>>   Applies on http://git.denx.de/u-boot.git branch master
>>>>>
>>>>>   config.mk |    2 +-
>>>>>   1 files changed, 1 insertions(+), 1 deletions(-)
>>>>>
>>>>> diff --git a/config.mk b/config.mk
>>>>> index ddaa477..11bc20d 100644
>>>>> --- a/config.mk
>>>>> +++ b/config.mk
>>>>> @@ -178,7 +178,7 @@ endif
>>>>>   # who are porting old code to latest mainline but not updating 
>>>>> $(AR).
>>>>>   ARFLAGS = $(error update your Makefile to use cmd_link_o_target 
>>>>> and not AR)
>>>>>   RELFLAGS= $(PLATFORM_RELFLAGS)
>>>>> -DBGFLAGS= -g # -DDEBUG
>>>>> +DBGFLAGS= -g -gdwarf-2 # -DDEBUG
>>>>>   OPTFLAGS= -Os #-fomit-frame-pointer
>>>>>
>>>>>   OBJCFLAGS += --gap-fill=0xff
>>>>
>>>>
>>>>
>>>> _______________________________________________
>>>> U-Boot mailing list
>>>> U-Boot at lists.denx.de
>>>> http://lists.denx.de/mailman/listinfo/u-boot
>>>>
>>>
>>>
>>>
>>> _______________________________________________
>>> U-Boot mailing list
>>> U-Boot at lists.denx.de
>>> http://lists.denx.de/mailman/listinfo/u-boot
>>>
>>
>>
>
>
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>

[U-Boot] [PATCH] config.mk:Update DBGFLAGS with dwarf information

[Graeme Russ]

Hi Prabhakar

On Mon, Jun 25, 2012 at 2:57 PM, Prabhakar Kushwaha
<prabhakar@freescale.com> wrote:
> Hi Mike/Graeme.
>
> Please help me in closing review related comments on this patch.
>

I can't offer any comments either way regarding -gdwarf-2 as I have
never done any runtime debugging of U-Boot

I was only pointing out that Mike had made a comment

That being said, I assume that this debugging information is stripped
for release builds, so I don't see the harm in adding it

Regards,

Graeme

[U-Boot] [PATCH] config.mk:Update DBGFLAGS with dwarf information

[Wolfgang Denk]

Dear Prabhakar Kushwaha,

In message <4FE7EFA1.2050208@freescale.com> you wrote:
> 
> Please help me in closing review related comments on this patch.

It appears most people here on the mailing list see not much need for
changing the debug flags, probbaly because nobody is using the single
tool that seems to need the additional flags.

Maybe instead of adding this to the mainline source tree you can
configure your debug tool to provide these settings on the make
command line, overwriting the default settings?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Gravitation cannot be held responsible for people falling in  love."
- Albert Einstein

[U-Boot] [PATCH] config.mk:Update DBGFLAGS with dwarf information

[Prabhakar Kushwaha]

Thanks Wolfgang for the reply.

Please find my reply in-lined


On 06/25/2012 12:51 PM, Wolfgang Denk wrote:
> Dear Prabhakar Kushwaha,
>
> In message <4FE7EFA1.2050208@freescale.com> you wrote:
>> Please help me in closing review related comments on this patch.
> It appears most people here on the mailing list see not much need for
> changing the debug flags, probbaly because nobody is using the single
> tool that seems to need the additional flags.

Yes.. it looks like the same :(

> Maybe instead of adding this to the mainline source tree you can
> configure your debug tool to provide these settings on the make
> command line, overwriting the default settings?
>

I will definitely check this point in debug tool.
Or
may be I put debug option somewhere else, other than top level config.mk.

Regards,
Prabhakar

[U-Boot] config.mk:Update DBGFLAGS with dwarf information

[Tom Rini]

On Tue, Feb 14, 2012 at 10:55:31PM -0000, Prabhakar Kushwaha wrote:

> Built u-boot elf file does not contain any dwarf informations by default. This
> information is required for debugging.
> 
> Add dwarf ver 2 flag in DBGFLAGS.
> 
> Signed-off-by: Radu Lazarescu <radu.lazarescu@freescale.com>
> Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com>

For posterity, with any recent enough toolchain, this shouldn't be
needed.  -g picks the best available debug format and that will be DWARF
v2 symbols (which gdb happily uses).

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20121015/404f700f/attachment.pgp>