From mboxrd@z Thu Jan  1 00:00:00 1970
From: Anatolij Gustschin <agust@denx.de>
Date: Sat, 20 Oct 2012 01:38:14 +0200
Subject: [U-Boot] [PATCH v4 4/5] cfb_console: Add support for some ANSI
 terminal escape codes
In-Reply-To: <1350648008-25514-5-git-send-email-pali.rohar@gmail.com>
References: <1327415291-13260-1-git-send-email-pali.rohar@gmail.com>
	<1350648008-25514-1-git-send-email-pali.rohar@gmail.com>
	<1350648008-25514-5-git-send-email-pali.rohar@gmail.com>
Message-ID: <20121020013814.651b9dcd@wker>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi,

On Fri, 19 Oct 2012 14:00:07 +0200
Pali Roh?r <pali.rohar@gmail.com> wrote:
...
> +		When CONFIG_CFB_CONSOLE_ANSI is defined, console will have
> +		ANSI terminal support. Needed for CONFIG_CMDLINE_EDITING.

What do you mean here? Doesn't command line editing work without ANSI
support in cfb?

> +
>  		When CONFIG_CFB_CONSOLE is defined, video console is
>  		default i/o. Serial console can be forced with
>  		environment 'console=serial'.
> diff --git a/drivers/video/cfb_console.c b/drivers/video/cfb_console.c
> index 9f7794f..3ed96d3 100644
> --- a/drivers/video/cfb_console.c
> +++ b/drivers/video/cfb_console.c
> @@ -385,6 +385,11 @@ static u32 eorx, fgx, bgx;	/* color pats */
>  
>  static int cfb_do_flush_cache;
>  
> +static char ansi_buf[10] = { 0, };

initialisation is not needed here. I've fixed some issues with this
patch, please test v5.

Thanks,
Anatolij