[U-Boot] [PATCH 01/14] arm, omap3: Define save_boot_params in lowlevel_init.S for SPL only

Marek Vasut
2012-01-25T18:00:47Z

> * Hide function save_boot_params if CONFIG_SPL_BUILD is not defined
> (function do nothing)

What do you mean by this statement here ?
>
> * Same behaviour as in file arch/arm/cpu/armv7/omap4/lowlevel_init.S

Eh?

> * This allow to implement board specified function save_boot_params in
> board code

I see ... do you want to write overridable function? Make it a weak alias?

M
>
> Signed-off-by: Pali Roh?r <pali.rohar@gmail.com>
> ---
> Changes since original version:
> - Fixed commit message
>
> arch/arm/cpu/armv7/omap3/lowlevel_init.S | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/cpu/armv7/omap3/lowlevel_init.S
> b/arch/arm/cpu/armv7/omap3/lowlevel_init.S index 2f6930b..c42c5dd 100644
> --- a/arch/arm/cpu/armv7/omap3/lowlevel_init.S
> +++ b/arch/arm/cpu/armv7/omap3/lowlevel_init.S
> @@ -35,15 +35,15 @@
> _TEXT_BASE:
> .word CONFIG_SYS_TEXT_BASE /* sdram load addr from config.mk */
>
> +#ifdef CONFIG_SPL_BUILD
> .global save_boot_params
> save_boot_params:
> -#ifdef CONFIG_SPL_BUILD
> ldr r4, =omap3_boot_device
> ldr r5, [r0, #0x4]
> and r5, r5, #0xff
> str r5, [r4]
> -#endif
> bx lr

Wasn't this jump intentionally left out from the macro ifdef block?

> +#endif
>
> .global omap3_gp_romcode_call
> omap3_gp_romcode_call: