[U-Boot] [PATCH v2 11/11] New board support: Nokia RX-51 aka N900

Wolfgang Denk
2012-04-29T12:49:46Z

Dear Pali =?ISO-8859-1?Q?Roh=E1r?=,

In message <2499233.2JzaJFJkCD@pali> you wrote:
>
> > Please stop sending base64 encoded patches! Send plain text
> > only!
>
> I used git format-patch and git send-email. Is there easy way how
> to tell this to git?

Yes: do not use characters that cause problems.

> > While it is a good idea to provide documentation, this is the
> > wrong place for it. Here in the commit message is about the
> > last place where most of the users will search for it. Please
> > provide a README for this board - either in the board
> > directory, or in doc/
>
> Is doc/README.nokia_rx51 correct place?

It ist what many other boards used, so it would be fine.

Personally, I don;t like this ever growing list of board specific
documentation in doc; my personal preference would be something like
board/nokia/rx51/README instead... Feel free to chose.

> > Comment appears to be misplaced.
>
> Ok, comment will be removed.

Rather fix it.

> > > +/* Maemo kernel 2.6.28 will crash if u-boot enable usb tty
> > > */
> > > +/*
> > > +#define CONFIG_USB_TTY
> > > +*/
> >
> > Please remove dead code.
>
> usb tty is usefull for debuging u-boot. because this device does
> not have easy access to serial console, usb tty is only option
> how to connect u-boot terminal to pc. but default (and still only
> one working on this device) kernel crash when u-boot enable usb
> tty. I want to have usb tty option in u-boot and belive that one
> day will be some upstream linux kernel with fixed usb drivers
> working on nokia n900.

As is, it is dead code and should be removed (not to mention that this
is another case of incorrect multi-line comment style).

Please feel free to add such a description to the documentation.

> > Incorrect multiline comment / please remove dead code.
>
> How to write correct comment?

See
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=Documentation/CodingStyle#l446

> Is there way how to decrease u-boot binary size?

Omit features ...

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
To the systems programmer, users and applications serve only to
provide a test load.