[U-Boot] [PATCH V2 4/5] ARM: tegra: select between Seaboard/Ventana at compile time

Stephen Warren
2012-10-19T21:50:16Z

On 10/19/2012 01:51 PM, Simon Glass wrote:
> Hi Stephen,
>
> On Thu, Oct 18, 2012 at 4:25 PM, Stephen Warren <swarren@wwwdotorg.org> wrote:
>> Seaboard and Ventana are very similar boards, and so share the seaboard.c
>> board file. The one difference needed so far is detected at run-time by
>> calling machine_is_ventana(). This bloats the Ventana build with code
>> that is never used. Switch to detecting Ventana at compile time to remove
>> bloat. This shaves ~5K off the SPL size on Ventana, and makes the SPL fit
>> within the max size.

>> diff --git a/board/nvidia/seaboard/seaboard.c b/board/nvidia/seaboard/seaboard.c

>> /* TODO: Remove this code when the SPI switch is working */
>> #ifndef CONFIG_SPI_UART_SWITCH
>> +#if CONFIG_MACH_TYPE != MACH_TYPE_VENTANA
>
> I guess this forks the board type again, so that it is no longer
> defined by the fdt. Is that what you intend, or do I have it wrong?

This particular conditional was never driven by DT anyway; the original
code called machine_is_ventana() which I believe would have been
evaluated at compile time (and if not, the run-time evaluation wouldn't
have been DT-driven).

I imagine the code I modified here will be ripped out soon anyway; you'd
agreed to removing all the SPI/UART switching logic on Seaboard once the
LCD patches were in; we can all just set the jumper to "UART" mode
instead of "GPIO-controlled" then:-)