public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Allen Martin <amartin@nvidia.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2 5/5] ARM: tegra: don't request GPIO from Seaboard's SPL
Date: Fri, 19 Oct 2012 22:58:29 -0700	[thread overview]
Message-ID: <20121020055829.GF25104@badger> (raw)
In-Reply-To: <1350602759-22605-5-git-send-email-swarren@wwwdotorg.org>

On Thu, Oct 18, 2012 at 04:25:59PM -0700, Stephen Warren wrote:
> From: Stephen Warren <swarren@nvidia.com>
> 
> Seaboard has a GPIO that switches an external mux between Tegra's debug
> UART and SPI flash. This is initialized from the SPL so that SPL debug
> output can be seen. Simplify the code that does this, and don't actually
> request the GPIO in the SPL; just program it. This saves ~4.5K from the
> size of the SPL, mostly BSS due to the large gpio_names[] table that is
> no longer required. This makes Seaboard's SPL fit within the current max
> size.
> 

Acked-by: Allen Martin <amartin@nvidia.com>

> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> ---
> v2: New patch to replace modification of CONFIG_SYS_TEXT_BASE.
> ---
>  board/nvidia/seaboard/seaboard.c |   14 ++++----------
>  1 files changed, 4 insertions(+), 10 deletions(-)
> 
> diff --git a/board/nvidia/seaboard/seaboard.c b/board/nvidia/seaboard/seaboard.c
> index 6dce57f..c08ca80 100644
> --- a/board/nvidia/seaboard/seaboard.c
> +++ b/board/nvidia/seaboard/seaboard.c
> @@ -26,6 +26,7 @@
>  #include <asm/arch/tegra.h>
>  #include <asm/arch/clock.h>
>  #include <asm/arch/funcmux.h>
> +#include <asm/arch/gpio.h>
>  #include <asm/arch/pinmux.h>
>  #include <asm/arch-tegra/mmc.h>
>  #include <asm/gpio.h>
> @@ -36,21 +37,14 @@
>  /* TODO: Remove this code when the SPI switch is working */
>  #ifndef CONFIG_SPI_UART_SWITCH
>  #if CONFIG_MACH_TYPE != MACH_TYPE_VENTANA
> -/*
> - * Routine: gpio_config_uart_seaboard
> - * Description: Force GPIO_PI3 low on Seaboard so UART4 works.
> - */
> -static void gpio_config_uart_seaboard(void)
> +void gpio_early_init_uart(void)
>  {
>  	/* Enable UART via GPIO_PI3 (port 8, bit 3) so serial console works */
> +#ifndef CONFIG_SPL_BUILD
>  	gpio_request(GPIO_PI3, NULL);
> +#endif
>  	gpio_direction_output(GPIO_PI3, 0);
>  }
> -
> -void gpio_early_init_uart(void)
> -{
> -	gpio_config_uart_seaboard();
> -}
>  #endif
>  #endif
>  
> -- 
> 1.7.0.4
> 

-- 
nvpublic

  parent reply	other threads:[~2012-10-20  5:58 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-18 23:25 [U-Boot] [PATCH V2 1/5] ARM: fix u-boot.lds for -ffunction-sections/-fdata-sections Stephen Warren
2012-10-18 23:25 ` [U-Boot] [PATCH V2 2/5] ARM: enhance u-boot.lds to detect over-sized SPL Stephen Warren
2012-10-19 19:52   ` Simon Glass
2012-10-20  5:49   ` Allen Martin
2012-10-18 23:25 ` [U-Boot] [PATCH V2 3/5] ARM: tegra: derive CONFIG_SPL_MAX_SIZE instead of hard-coding it Stephen Warren
2012-10-19 19:49   ` Simon Glass
2012-10-20  5:53   ` Allen Martin
2012-10-18 23:25 ` [U-Boot] [PATCH V2 4/5] ARM: tegra: select between Seaboard/Ventana at compile time Stephen Warren
2012-10-19 19:51   ` Simon Glass
2012-10-19 21:50     ` Stephen Warren
2012-10-20  5:54   ` Allen Martin
2012-10-22 16:09     ` Stephen Warren
2012-10-22 17:26       ` Allen Martin
2012-10-18 23:25 ` [U-Boot] [PATCH V2 5/5] ARM: tegra: don't request GPIO from Seaboard's SPL Stephen Warren
2012-10-19 19:53   ` Simon Glass
2012-10-20  5:58   ` Allen Martin [this message]
2012-10-20  5:46 ` [U-Boot] [PATCH V2 1/5] ARM: fix u-boot.lds for -ffunction-sections/-fdata-sections Allen Martin
2012-10-26 21:25 ` Albert ARIBAUD
2012-10-26 21:44   ` Albert ARIBAUD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121020055829.GF25104@badger \
    --to=amartin@nvidia.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox