From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] HACK: fix return value of serial_assign to get printfs working again
Date: Sat, 20 Oct 2012 10:19:56 +0200 [thread overview]
Message-ID: <201210201019.56332.marex@denx.de> (raw)
In-Reply-To: <1350717121-4657-1-git-send-email-amartin@nvidia.com>
Dear Allen Martin,
> This reverts a recent change to serial_assign() that broke printfs on
> tegra. I don't think this is the real fix, but I'm just putting this
> out for others who want to test tegra patches for the other
> regressions.
>
> Signed-off-by: Allen Martin <amartin@nvidia.com>
Indeed, NAK. Please fix iomux.c, see the comment on how serial_assign() is
(mis)used there. Thanks!
> ---
> drivers/serial/serial.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/serial/serial.c b/drivers/serial/serial.c
> index e0886d5..f1c55bf 100644
> --- a/drivers/serial/serial.c
> +++ b/drivers/serial/serial.c
> @@ -268,7 +268,7 @@ int serial_assign(const char *name)
> return 0;
> }
>
> - return -EINVAL;
> + return 1;
> }
>
> /**
Best regards,
Marek Vasut
prev parent reply other threads:[~2012-10-20 8:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-20 7:12 [U-Boot] [PATCH] HACK: fix return value of serial_assign to get printfs working again Allen Martin
2012-10-20 8:19 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201210201019.56332.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox