* [U-Boot] [PATCH] HACK: fix return value of serial_assign to get printfs working again
@ 2012-10-20 7:12 Allen Martin
2012-10-20 8:19 ` Marek Vasut
0 siblings, 1 reply; 2+ messages in thread
From: Allen Martin @ 2012-10-20 7:12 UTC (permalink / raw)
To: u-boot
This reverts a recent change to serial_assign() that broke printfs on
tegra. I don't think this is the real fix, but I'm just putting this
out for others who want to test tegra patches for the other
regressions.
Signed-off-by: Allen Martin <amartin@nvidia.com>
---
drivers/serial/serial.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/serial/serial.c b/drivers/serial/serial.c
index e0886d5..f1c55bf 100644
--- a/drivers/serial/serial.c
+++ b/drivers/serial/serial.c
@@ -268,7 +268,7 @@ int serial_assign(const char *name)
return 0;
}
- return -EINVAL;
+ return 1;
}
/**
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [U-Boot] [PATCH] HACK: fix return value of serial_assign to get printfs working again
2012-10-20 7:12 [U-Boot] [PATCH] HACK: fix return value of serial_assign to get printfs working again Allen Martin
@ 2012-10-20 8:19 ` Marek Vasut
0 siblings, 0 replies; 2+ messages in thread
From: Marek Vasut @ 2012-10-20 8:19 UTC (permalink / raw)
To: u-boot
Dear Allen Martin,
> This reverts a recent change to serial_assign() that broke printfs on
> tegra. I don't think this is the real fix, but I'm just putting this
> out for others who want to test tegra patches for the other
> regressions.
>
> Signed-off-by: Allen Martin <amartin@nvidia.com>
Indeed, NAK. Please fix iomux.c, see the comment on how serial_assign() is
(mis)used there. Thanks!
> ---
> drivers/serial/serial.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/serial/serial.c b/drivers/serial/serial.c
> index e0886d5..f1c55bf 100644
> --- a/drivers/serial/serial.c
> +++ b/drivers/serial/serial.c
> @@ -268,7 +268,7 @@ int serial_assign(const char *name)
> return 0;
> }
>
> - return -EINVAL;
> + return 1;
> }
>
> /**
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-10-20 8:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-20 7:12 [U-Boot] [PATCH] HACK: fix return value of serial_assign to get printfs working again Allen Martin
2012-10-20 8:19 ` Marek Vasut
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox