From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Sat, 20 Oct 2012 10:39:18 +0200 Subject: [U-Boot] [PATCH V2 3/3] fs: add partition switch libary, implement ls and fsload commands In-Reply-To: <5081B384.4000609@ti.com> References: <1349981969-26113-1-git-send-email-swarren@wwwdotorg.org> <5081A96D.4070901@wwwdotorg.org> <5081B384.4000609@ti.com> Message-ID: <201210201039.19109.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Tom Rini, > On 10/19/12 12:26, Stephen Warren wrote: > > [snip] > > > Yes, I suppose I could: > > > > * Add a bit-mask of legal filesystems as a parameter to > > fs_set_blk_dev(). > > > > * Move the body of do_fsload() into some common called by > > do_fsload(), do_ext2load(), do_fatload(), each passing in the > > appropriate bit-mask, which gets passed down to fs_set_blk_dev(). > > > > That'd be easy, and probably entail only extremely minimal > > code-size increases for an ext2-only or FAT-only build; just a few > > bytes for a few more function calls. Sound like a plan? > > Sounds good to me. I bet you'll find some other clean-ups while > you're in there. Marek, any comments from the DM perspective here? CCing pavel, block goo is on his slate. Best regards, Marek Vasut