[U-Boot] [PATCH v3 2/5] arm bootm: Do not append zero ATAG_MEM

Marek Vasut
2012-10-14T00:27:05Z

Dear Pali Roh?r,

> On Sunday 14 October 2012 02:17:01 Marek Vasut wrote:
> > Dear Pali Roh?r,
> >
> > > On Sunday 14 October 2012 01:45:06 Marek Vasut wrote:
> > > > > for (i = 0; i < CONFIG_NR_DRAM_BANKS; i++) {
> > > > >
> > > > > + if (bd->bi_dram[i].size == 0)
> > > > > + continue;
> > > >
> > > > This doesn't look right at all, your board is misconfigured
> > > > if
> > > > bd->bi_dram[i] == 0. Did you misconfigure
> > > > CONFIG_NR_DRAM_BANKS
> > > > ?
> > >
> > > On some N900 devices there are two banks and on some only
> > > one. If there is only one it has size 256 MB and if there
> > > are two both has 128 MB. CONFIG_NR_DRAM_BANKS must be
> > > specified at compile time, but for N900 I need runtime
> > > detection.
> >
> > How can that be? Are these two banks contiguous?
>
> Yes.

And how does the memory map differ in case of device with one 256MB block then ?

Best regards,
Marek Vasut