public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] nand_spl: Define nand_select function
Date: Tue, 23 Oct 2012 10:46:03 -0700	[thread overview]
Message-ID: <20121023174603.GC6206@bill-the-cat> (raw)
In-Reply-To: <5086D473.70903@gmail.com>

On Tue, Oct 23, 2012 at 11:01:31PM +0530, Vikram Narayanan wrote:
> On 10/23/2012 9:17 PM, Tom Rini wrote:
> >On Tue, Oct 23, 2012 at 04:51:05PM +0530, Vikram Narayanan wrote:
> >
> >>Split up the selection of nand_chip from nand_init to a separate
> >>function. This is just to make it a little consistent as we've
> >>nand_deselect function.
> >>
> >>Also use it in spl_nand_load_image function.
> >>
> >>Signed-off-by: Vikram Narayanan<vikram186@gmail.com>
> >>Cc: Stefan Roese<sr@denx.de>
> >
> >What does this allow for us to do next?  We've added a few bytes to SPL
> >and we're already close to being too large sometimes.
> 
> Yep. 12 bytes added. If SPL is too much loaded to include this, the
> patch shall be dropped.

Since we're trying to squish down to 4kb and every byte counts, yes,
this might well be.  Thanks.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20121023/ad3e6057/attachment.pgp>

      reply	other threads:[~2012-10-23 17:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-23 11:21 [U-Boot] [PATCH] nand_spl: Define nand_select function Vikram Narayanan
2012-10-23 15:47 ` Tom Rini
2012-10-23 17:31   ` Vikram Narayanan
2012-10-23 17:46     ` Tom Rini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121023174603.GC6206@bill-the-cat \
    --to=trini@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox