From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 1/3] USB: make usb_kbd obey USB DMA alignment requirements
Date: Wed, 24 Oct 2012 00:03:34 +0200 [thread overview]
Message-ID: <201210240003.34903.marex@denx.de> (raw)
In-Reply-To: <20121023170235.GF13201@badger>
Dear Allen Martin,
> On Tue, Oct 23, 2012 at 09:51:06AM -0700, Stephen Warren wrote:
> > On 10/22/2012 11:47 PM, Allen Martin wrote:
> > > Change usb_kbd driver to obey alignment requirements for USB DMA on
> > > the buffer used for data transfer. This is necessary for
> > > architectures that enable dcache and enable USB DMA.
> >
> > The series,
> > Tested-by: Stephen Warren <swarren@nvidia.com>
> >
> > BTW, I tested tegra-kbc too, and that does indeed currently work (at
> > least in my local dev branch based on u-boot/master).
>
> Yes, I also tried on a seaboard with internal keyboard and it works,
> although once the USB keyboard driver loads the internal keyboard
> stops working. I haven't tracked down why, but it seems like a bug I
> can live with for now as seaboards with internal keyboards are pretty
> rare these days, and how many keyboards do you need in u-boot anyway?
Good thing you pointed it out. Please let's not ignore a bug. How come it
happens? What happens if you have two usb keyboards connected?
> :^)
> :
> > Note that patch 2 has a merge conflict with the following patch in
> > u-boot-tegra/next, since I assume your series is based on u-boot/master
> > not u-boot-tegra/next:
> >
> > 799f182 ARM: tegra: use standard variables to define load addresses
> >
> > It's pretty simple to resolve though.
>
> Yes, I based it on u-boot/master, once we figure out what trees each
> patch is destined for I'll rebase appropriately.
I pushed u-boot-usb/master today, can you check if it still applies ?
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-10-23 22:03 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-23 5:47 [U-Boot] [PATCH v2 1/3] USB: make usb_kbd obey USB DMA alignment requirements Allen Martin
2012-10-23 5:47 ` [U-Boot] [PATCH v2 2/3] tegra: move TEGRA_DEVICE_SETTINGS to tegra-common-post.h Allen Martin
2012-10-23 7:27 ` Marek Vasut
2012-10-23 16:36 ` Stephen Warren
2012-10-23 22:01 ` Marek Vasut
2012-10-23 22:18 ` Stephen Warren
2012-10-24 0:30 ` Allen Martin
2012-11-02 20:06 ` Allen Martin
2012-11-02 20:40 ` Marek Vasut
2012-10-23 16:41 ` Stephen Warren
2012-10-23 5:47 ` [U-Boot] [PATCH v2 3/3] tegra: Enable USB keyboard Allen Martin
2012-10-23 7:26 ` [U-Boot] [PATCH v2 1/3] USB: make usb_kbd obey USB DMA alignment requirements Marek Vasut
2012-10-23 16:31 ` Stephen Warren
2012-10-23 16:51 ` Allen Martin
2012-10-23 22:04 ` Marek Vasut
2012-10-23 16:51 ` Stephen Warren
2012-10-23 17:02 ` Allen Martin
2012-10-23 22:03 ` Marek Vasut [this message]
2012-10-24 0:39 ` Allen Martin
2012-10-24 0:46 ` Allen Martin
2012-10-24 7:31 ` Marek Vasut
2012-10-24 17:24 ` Allen Martin
2012-10-24 20:17 ` Marek Vasut
2012-10-24 20:41 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201210240003.34903.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox