From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Wed, 24 Oct 2012 00:03:34 +0200
Subject: [U-Boot] [PATCH v2 1/3] USB: make usb_kbd obey USB DMA
	alignment requirements
In-Reply-To: <20121023170235.GF13201@badger>
References: <1350971254-11412-1-git-send-email-amartin@nvidia.com>
	<5086CAFA.4010409@wwwdotorg.org> <20121023170235.GF13201@badger>
Message-ID: <201210240003.34903.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Allen Martin,

> On Tue, Oct 23, 2012 at 09:51:06AM -0700, Stephen Warren wrote:
> > On 10/22/2012 11:47 PM, Allen Martin wrote:
> > > Change usb_kbd driver to obey alignment requirements for USB DMA on
> > > the buffer used for data transfer.  This is necessary for
> > > architectures that enable dcache and enable USB DMA.
> > 
> > The series,
> > Tested-by: Stephen Warren <swarren@nvidia.com>
> > 
> > BTW, I tested tegra-kbc too, and that does indeed currently work (at
> > least in my local dev branch based on u-boot/master).
> 
> Yes, I also tried on a seaboard with internal keyboard and it works,
> although once the USB keyboard driver loads the internal keyboard
> stops working.  I haven't tracked down why, but it seems like a bug I
> can live with for now as seaboards with internal keyboards are pretty
> rare these days, and how many keyboards do you need in u-boot anyway?

Good thing you pointed it out. Please let's not ignore a bug. How come it 
happens? What happens if you have two usb keyboards connected?

> :^)
> :
> > Note that patch 2 has a merge conflict with the following patch in
> > u-boot-tegra/next, since I assume your series is based on u-boot/master
> > not u-boot-tegra/next:
> > 
> > 799f182 ARM: tegra: use standard variables to define load addresses
> > 
> > It's pretty simple to resolve though.
> 
> Yes, I based it on u-boot/master, once we figure out what trees each
> patch is destined for I'll rebase appropriately.

I pushed u-boot-usb/master today, can you check if it still applies ?

Best regards,
Marek Vasut