From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Bradford <andrew@bradfordembedded.com>
Date: Wed, 24 Oct 2012 17:07:28 -0400
Subject: [U-Boot] [PATCH v3 4/4] am335x_evm: Enable use of UART{1, 2, 3,
 4, 5}
In-Reply-To: <20121024203906.GD8148@bill-the-cat>
References: <1351110182-22681-1-git-send-email-andrew@bradfordembedded.com>
	<1351110182-22681-5-git-send-email-andrew@bradfordembedded.com>
	<20121024203906.GD8148@bill-the-cat>
Message-ID: <20121024170728.11b875c7@brick>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Wed, 24 Oct 2012 13:39:06 -0700
Tom Rini <trini@ti.com> wrote:

> On Wed, Oct 24, 2012 at 04:23:02PM -0400, Andrew Bradford wrote:
> 
> > Add targets of am335x_evm_uart{1,2,3,4,5} to have serial
> > input/output on UART{1,2,3,4,5} for use with the Beaglebone RS232
> > cape, am335x_evm daughterboard, and other custom configurations.
> > 
> > Signed-off-by: Andrew Bradford <andrew@bradfordembedded.com>
> > ---
> > Changes from v2:
> > 	Set CONS_INDEX and SERIALX in the target options instead of
> > 	using AM33XX_UART_SELECT resulting in an easier to read
> > config. Changes from v1:
> > 	Add UART3 target and register location
> > 
> >  boards.cfg                   |    5 +++++
> >  include/configs/am335x_evm.h |   12 +++++++++++-
> >  2 files changed, 16 insertions(+), 1 deletion(-)
> > 
> > diff --git a/boards.cfg b/boards.cfg
> > index b14a08f..0024033 100644
> > --- a/boards.cfg
> > +++ b/boards.cfg
> > @@ -226,6 +226,11 @@ integratorap_cm946es         arm
> > arm946es    integrator          armltd integratorcp_cm946es
> > arm         arm946es    integrator          armltd
> > -               integratorcp:CM946ES ca9x4_ct_vxp
> > arm         armv7       vexpress            armltd
> > am335x_evm                   arm         armv7
> > am335x              ti             am33xx
> > +am335x_evm_uart1             arm         armv7
> > am335x              ti             am33xx
> > am335x_evm:SERIAL2=1,CONS_INDEX=2
> 
> This could just be am335x_evm:SERIAL2,CONS_INDEX=2 right?

Right.

> We don't
> check the value of CONFIG_SERIAL2 (or 3 or ..) just tha it's set,
> correct?

Correct.

> [snip]
> >  /*
> > - * select serial console configuration
> > + * select serial console configuration, uart0 always enabled
> >   */
> >  #define CONFIG_SERIAL1			1
> > +#ifndef CONFIG_CONS_INDEX
> >  #define CONFIG_CONS_INDEX		1
> > +#endif /* CONFIG_CONS_INDEX */
> 
> Just amke CONS_INDEX=1 be the default in boards.cfg.  Makes it clear
> all around when folks add new config targets they must set that.

Will do.

v4 coming.

Thanks,
Andrew