[U-Boot] [PATCH] common: fix help command breakage

Anatolij Gustschin
2012-11-07T22:23:50Z

Hi,

On Mon, 5 Nov 2012 19:51:11 -0600
Kim Phillips <kim.phillips@freescale.com> wrote:

> commit 199adb601ff34bdbbd0667fac80dfe0a87bffc2b "common/misc: sparse
> fixes" broke the help command trying to fix the sparse error
> "command.c:44:38: error: bad constant expression".
>
> As Henrik points out, the fix was bad because the commit used
> CONFIG_SYS_MAXARGS whereas the code intended to use the maximum
> number of commands (not arguments to a command).
>
> this patch fixes both by making the allocation manually on the heap.
>
> Reported-by: Henrik Nordstr?m <henrik@henriknordstrom.net>
> Signed-off-by: Kim Phillips <kim.phillips@freescale.com>
> ---
> tested on an 8572ds board
>
> common/command.c | 21 ++++++++++++---------
> 1 file changed, 12 insertions(+), 9 deletions(-)

Applied to staging/agust at denx.de. Thanks!

Anatolij