public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] serial: add environment control for SERIAL_MULTI
Date: Fri, 26 Oct 2012 12:27:14 +0200	[thread overview]
Message-ID: <201210261227.14463.marex@denx.de> (raw)
In-Reply-To: <CANr=Z=Z+hBV1zgePBmGR64=Y6CVw-eDj2pgkeRr63JqmVF2b2g@mail.gmail.com>

Dear Joe Hershberger,

> Hi Allen,
> 
> On Thu, Oct 25, 2012 at 5:50 PM, Allen Martin <amartin@nvidia.com> wrote:
> > On Thu, Oct 25, 2012 at 03:46:01PM -0700, Joe Hershberger wrote:
> >> Hi Stephen,
> >> 
> >> On Thu, Oct 25, 2012 at 5:43 PM, Stephen Warren <swarren@wwwdotorg.org> 
wrote:
> >> > On 10/25/2012 03:59 PM, Allen Martin wrote:
> >> >> Add a new special environment variable "serial" that allows selection
> >> >> of serial device when CONFIG_SERIAL_MULTI is defined.  This replaces
> >> >> the existing calls to serial_assign() from cmd_nvedit.c and iomux.c
> >> >> that were not doing anything.
> >> > 
> >> > So I think this requires (for example) the following environment
> >> > variables:
> >> > 
> >> > stdout=serial
> >> > serial=eserial0
> >> > 
> >> > Is it possible to allow the following instead:
> >> > 
> >> > stdout=eserial0
> >> 
> >> This is precisely what the patch I had pre-Marek serial did.
> > 
> > In your patch would "stdout=serial" still work for case where there is
> > only one serial port?  I think it's important to try to preserve that
> > to no be too disruptive.
> 
> It used to support stdout=serial based on not being
> CONFIG_SERIAL_MULTI.  Now that that's gone, I'm guessing it would
> simply be based on only having one registered serial device.
> 
> >> > That way, one could presumably set:
> >> > 
> >> > stdout=eserial0,eserial3
> >> 
> >> Though it didn't allow this.
> > 
> > Shouldn't that be (nearly) transparent through iomux?
> 
> If that's what iomux does, then sure!  I haven't used I/O mux on a
> device before.

This is what we should do, indeed.

Best regards,
Marek Vasut

      reply	other threads:[~2012-10-26 10:27 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-25 21:59 [U-Boot] [PATCH] serial: add environment control for SERIAL_MULTI Allen Martin
2012-10-25 22:29 ` Marek Vasut
2012-10-25 22:36 ` Tom Rini
2012-10-25 22:36 ` Joe Hershberger
2012-10-25 22:45   ` Stephen Warren
2012-10-25 22:47     ` Joe Hershberger
2012-10-25 22:53       ` Allen Martin
2012-10-25 23:18         ` Joe Hershberger
2012-10-25 23:21           ` Allen Martin
2012-10-25 22:43 ` Stephen Warren
2012-10-25 22:46   ` Joe Hershberger
2012-10-25 22:50     ` Allen Martin
2012-10-25 23:17       ` Joe Hershberger
2012-10-26 10:27         ` Marek Vasut [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201210261227.14463.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox