From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Fri, 26 Oct 2012 12:27:14 +0200 Subject: [U-Boot] [PATCH] serial: add environment control for SERIAL_MULTI In-Reply-To: References: <1351202390-11415-1-git-send-email-amartin@nvidia.com> <20121025225057.GD12183@badger> Message-ID: <201210261227.14463.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Joe Hershberger, > Hi Allen, > > On Thu, Oct 25, 2012 at 5:50 PM, Allen Martin wrote: > > On Thu, Oct 25, 2012 at 03:46:01PM -0700, Joe Hershberger wrote: > >> Hi Stephen, > >> > >> On Thu, Oct 25, 2012 at 5:43 PM, Stephen Warren wrote: > >> > On 10/25/2012 03:59 PM, Allen Martin wrote: > >> >> Add a new special environment variable "serial" that allows selection > >> >> of serial device when CONFIG_SERIAL_MULTI is defined. This replaces > >> >> the existing calls to serial_assign() from cmd_nvedit.c and iomux.c > >> >> that were not doing anything. > >> > > >> > So I think this requires (for example) the following environment > >> > variables: > >> > > >> > stdout=serial > >> > serial=eserial0 > >> > > >> > Is it possible to allow the following instead: > >> > > >> > stdout=eserial0 > >> > >> This is precisely what the patch I had pre-Marek serial did. > > > > In your patch would "stdout=serial" still work for case where there is > > only one serial port? I think it's important to try to preserve that > > to no be too disruptive. > > It used to support stdout=serial based on not being > CONFIG_SERIAL_MULTI. Now that that's gone, I'm guessing it would > simply be based on only having one registered serial device. > > >> > That way, one could presumably set: > >> > > >> > stdout=eserial0,eserial3 > >> > >> Though it didn't allow this. > > > > Shouldn't that be (nearly) transparent through iomux? > > If that's what iomux does, then sure! I haven't used I/O mux on a > device before. This is what we should do, indeed. Best regards, Marek Vasut