[U-Boot] [PATCH 1/5] msm7x30: Add support for low speed uart on msm7x30

Albert ARIBAUD
2012-02-28T23:44:15Z

Hi Mohamed,

Le 16/02/2012 03:59, mohamed.haneef at lntinfotech.com a ?crit :

> +#define UART_CR_TX_DISABLE (1<< 3)
> +#define UART_CR_TX_ENABLE (1<< 3)

I doubt the same bit value can mean both enable and disable.

> +#define UART_CR_RX_DISABLE (1<< 3)
> +#define UART_CR_RX_ENABLE (1<< 3)

Ditto.

Besides, neither of these defines are used anyway. What's the point of
having them? I suspect many others are unused, too. Unless there is a
compelling reason to keep useless defines, remove them.

> The contents of this e-mail and any attachment(s) may contain
> confidential or privileged information for the intended recipient(s).
> Unintended recipients are prohibited from taking action on the basis
> of information in this e-mail and using or disseminating the
> information, and must notify the sender and delete it from their
> system. L&T Infotech will not accept responsibility or liability for
> the accuracy or completeness of, or the presence of any virus or
> disabling code in this e-mail"

Please do not post with this footer on the list. It os obnoxious (and
quite purposeless on a public list :) )

Amicalement,
--
Albert.