From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Tue, 30 Oct 2012 13:33:32 +0100
Subject: [U-Boot] [PATCH 5/8] tegra: usb: move controller init into
	start_port
In-Reply-To: <1351599137.1434.15.camel@tellur>
References: <1351588973-20699-1-git-send-email-dev@lynxeye.de>
	<201210301159.35457.marex@denx.de>
	<1351599137.1434.15.camel@tellur>
Message-ID: <201210301333.32661.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Lucas Stach,

[...]

> > > -static int add_port(struct fdt_usb *config)
> > 
> > Fix the comment instead of removing it?
> 
> I don't think that this comment adds any real value. The whole function
> which this comment refers to is removed and it's content split between
> board_usb_init and ehci_hcd_init, which are self explanatory.

Then add a proper comment please. Call me a docu-nazi, but I'd really love u-
boot nicely and properly documented, please.

[1] http://www.denx.de/wiki/U-Boot/CodingStyle

Best regards,
Marek Vasut