From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Wed, 31 Oct 2012 17:41:08 +0100 Subject: [U-Boot] [PATCH] pxa: Disable dcache on palmld, palmtc, zipitz2 In-Reply-To: <50913966.2010808@ti.com> References: <1351640333-12431-1-git-send-email-sjg@chromium.org> <201210311255.51276.marex@denx.de> <50913966.2010808@ti.com> Message-ID: <201210311741.08889.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Tom Rini, > On 10/31/12 04:55, Marek Vasut wrote: > > Dear Simon Glass, > > > >> These platforms don't include dcache support. Define > >> CONFIG_SYS_DCACHE_OFF so that functions don't try to call > >> non-existent routines like flush_dcache_range(). > >> > >> Signed-off-by: Simon Glass > > > > Is that needed? Why not fix PXA by defining stub cache routines ? > > Adding stubs sounds more like a work-around than disabling support > that we won't have to me. Yes, but then, the stubs will be optimized out. I see using CONFIG_SYS_DCACHE_OFF being abused here. Every platform should implement at least cache operations stubs, then it'd be valid to use CONFIG_SYS_DCACHE_OFF to indicate the cache shall always be off. But the code would at least compile and work with CONFIG_SYS_DCACHE_OFF enabled or disabled. We might eventually even be able to weed out this CONFIG_SYS_DCACHE_OFF option. Best regards, Marek Vasut