public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] WIP: Changes to patman libraries
Date: Thu, 01 Nov 2012 00:40:27 +0100	[thread overview]
Message-ID: <20121031234027.8DBEC2005BD@gemini.denx.de> (raw)
In-Reply-To: <CAPnjgZ3us4yoeqOHxozQ6VPHXhaKJdLWfb0HPWHWvnnUaZ0Ghg@mail.gmail.com>

Dear Simon,

In message <CAPnjgZ3us4yoeqOHxozQ6VPHXhaKJdLWfb0HPWHWvnnUaZ0Ghg@mail.gmail.com> you wrote:
> 
> >> These changes are required to the patman libraries. This is not a proper
> >> patch yet, just sometime to try out.
> >
> > ...are required.  So.  And why exactly?  Or what is the purpose of
> > these changes?
> 
> Just so that people can try the builder if they want to. The patches
> enhance functions in patman, mostly on the git side, so that the
> builder can do its job. For example it needs to clone a repo, checkout
> code into a different directory and work with branches a bit more.
> 
> This is not a useful patch for any other purpose (e.g. review) - it is
> just a lump of code. If there is interest in this it will need to be
> turned into proper patches.

Hm...  I apologize, but I'm just an old man, and a bit slow of wits
these days.  I cannot review any such code without knowing what it is
suppose to acchieve.  Maybe you should add such explanations to the
commit message, even if it's only a WIP patch?  I would definitely
appreciate this (as it would help me to understand what this is all
about).

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Half of the people in the world are below average.

  reply	other threads:[~2012-10-31 23:40 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-31 21:25 [U-Boot] [PATCH 1/2] WIP: Changes to patman libraries Simon Glass
2012-10-31 21:25 ` [U-Boot] [PATCH 2/2] WIP: Test version of buildman - U-Boot builder Simon Glass
2012-10-31 22:46   ` Wolfgang Denk
2012-10-31 22:51     ` Tom Rini
2012-10-31 23:08       ` Simon Glass
2012-10-31 23:37         ` Wolfgang Denk
2012-11-01  0:11           ` Simon Glass
2012-11-01  1:18             ` Tom Rini
2012-11-01  4:17               ` Andy Fleming
2012-11-01 21:01                 ` Simon Glass
2012-11-01 23:29                   ` Tom Rini
2012-12-01 20:55                     ` Simon Glass
2012-10-31 22:42 ` [U-Boot] [PATCH 1/2] WIP: Changes to patman libraries Wolfgang Denk
2012-10-31 23:12   ` Simon Glass
2012-10-31 23:40     ` Wolfgang Denk [this message]
2012-11-01  0:04       ` Simon Glass
2012-11-01 20:59         ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121031234027.8DBEC2005BD@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox