From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Thu, 01 Nov 2012 00:40:27 +0100 Subject: [U-Boot] [PATCH 1/2] WIP: Changes to patman libraries In-Reply-To: References: <1351718752-6832-1-git-send-email-sjg@chromium.org> <20121031224244.46B20200630@gemini.denx.de> Message-ID: <20121031234027.8DBEC2005BD@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Simon, In message you wrote: > > >> These changes are required to the patman libraries. This is not a proper > >> patch yet, just sometime to try out. > > > > ...are required. So. And why exactly? Or what is the purpose of > > these changes? > > Just so that people can try the builder if they want to. The patches > enhance functions in patman, mostly on the git side, so that the > builder can do its job. For example it needs to clone a repo, checkout > code into a different directory and work with branches a bit more. > > This is not a useful patch for any other purpose (e.g. review) - it is > just a lump of code. If there is interest in this it will need to be > turned into proper patches. Hm... I apologize, but I'm just an old man, and a bit slow of wits these days. I cannot review any such code without knowing what it is suppose to acchieve. Maybe you should add such explanations to the commit message, even if it's only a WIP patch? I would definitely appreciate this (as it would help me to understand what this is all about). Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Half of the people in the world are below average.