From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 16/17] console: Enable function to display console info
Date: Sat, 03 Nov 2012 16:15:03 +0100 [thread overview]
Message-ID: <20121103151503.8ABCE200255@gemini.denx.de> (raw)
In-Reply-To: <1351902453-27956-17-git-send-email-sjg@chromium.org>
Dear Simon Glass,
In message <1351902453-27956-17-git-send-email-sjg@chromium.org> you wrote:
> The CONFIG_SYS_CONSOLE_INFO_QUIET option should suppress the console
> information, but allow boards to display it later if required. Adjust
> the code to support this.
>
> This is used to avoid printing the information while the LCD display
> is not ready, since it only becomes ready when stdio init is complete.
>
> BRANCH=snow
Please get such comments out of the commit messages.
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
> common/console.c | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
This is broken. You miss the fact that stdio_print_current_devices()
gets called in a number of other places as well (you should have
asked yourself why it isn't a static function). See at least
board/mpl/mip405/mip405.c
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"In matrimony, to hesitate is sometimes to be saved." - Butler
next prev parent reply other threads:[~2012-11-03 15:15 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-03 0:27 [U-Boot] [PATCH 0/17] Various patches in common/ Simon Glass
2012-11-03 0:27 ` [U-Boot] [PATCH 01/17] arm: Add new bootstage step for the main loop Simon Glass
2012-11-03 15:12 ` Wolfgang Denk
2012-11-07 0:54 ` Simon Glass
2012-11-03 0:27 ` [U-Boot] [PATCH 02/17] Add gettime command Simon Glass
2012-11-03 8:22 ` Luka Perkov
2012-11-15 22:23 ` Simon Glass
2012-11-03 15:24 ` Wolfgang Denk
2012-11-15 22:15 ` Simon Glass
2012-11-03 0:27 ` [U-Boot] [PATCH 03/17] Add a command to read raw blocks from a partition Simon Glass
2012-11-03 0:27 ` [U-Boot] [PATCH 04/17] Fix use of conditional LMB Simon Glass
2012-11-03 0:27 ` [U-Boot] [PATCH 05/17] stdio: remove useless strncpy Simon Glass
2012-11-03 15:31 ` Wolfgang Denk
2012-11-15 22:25 ` Simon Glass
2012-11-03 0:27 ` [U-Boot] [PATCH 06/17] env: Add the ability to merge the saved env with the default Simon Glass
2012-11-03 15:28 ` Wolfgang Denk
2012-11-07 0:53 ` Simon Glass
2012-11-03 0:27 ` [U-Boot] [PATCH 07/17] Add coreboot version to u-boot's version command Simon Glass
2012-11-03 0:27 ` [U-Boot] [PATCH 08/17] Update time command to avoid using get_timer_masked() Simon Glass
2012-11-03 0:27 ` [U-Boot] [PATCH 09/17] Add sha256 command for hashing Simon Glass
2012-11-03 15:23 ` Wolfgang Denk
2012-11-22 14:48 ` Simon Glass
2012-11-03 0:27 ` [U-Boot] [PATCH 10/17] edid: Library of EDID decode and print Simon Glass
2012-11-03 0:27 ` [U-Boot] [PATCH 11/17] edid: Add I2C command for printing the EDID Simon Glass
2012-11-03 0:27 ` [U-Boot] [PATCH 12/17] fdt: edid: Enable fdt_add_edid() function when CONFIG_LCD defined Simon Glass
2012-11-03 0:27 ` [U-Boot] [PATCH 13/17] mmc: Fix incorrect handling of 'read' & 'write' commands Simon Glass
2012-11-03 0:27 ` [U-Boot] [PATCH 14/17] console: Call overwrite_console before searching for console devices Simon Glass
2012-11-03 15:32 ` Wolfgang Denk
2012-11-07 21:28 ` Simon Glass
2012-11-08 10:33 ` Wolfgang Denk
2012-11-03 0:27 ` [U-Boot] [PATCH 15/17] Add console command to access io space registers Simon Glass
2012-11-03 15:26 ` Wolfgang Denk
2012-11-15 23:28 ` Vadim Bendebury
2012-11-03 0:27 ` [U-Boot] [PATCH 16/17] console: Enable function to display console info Simon Glass
2012-11-03 15:15 ` Wolfgang Denk [this message]
2012-11-15 23:24 ` Simon Glass
2012-11-03 0:27 ` [U-Boot] [PATCH 17/17] tpm: Add TPM stress test Simon Glass
2012-11-03 15:29 ` Wolfgang Denk
2012-11-03 20:40 ` Simon Glass
2012-11-19 23:50 ` Marek Vasut
2012-11-20 1:11 ` Simon Glass
2012-11-20 2:16 ` Marek Vasut
2012-11-20 7:04 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121103151503.8ABCE200255@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox