[U-Boot] [PATCH v4 1/2] arm: move C runtime setup code in crt0.S

Simon Glass
2013-01-05T01:00:26Z

Hi Albert,

On Wed, Dec 26, 2012 at 12:41 PM, Simon Glass <sjg@chromium.org> wrote:
> Hi Albert,
>
> On Sun, Dec 23, 2012 at 7:03 AM, Albert ARIBAUD
> <albert.u.boot@aribaud.net> wrote:
>> Hi Simon,
>>
>> On Fri, 30 Nov 2012 14:10:01 -0800, Simon Glass <sjg@chromium.org>
>> wrote:
>>
>>> >> I tried to test it on a snow (exynos5250) but couldn't really sync up
>>> >> with our tree, so gave up. I am not completely sure about how the
>>> >> CONFIG_SPL_BUILD stuff fits together in start.S and I got a build
>>> >> error I wasn't sure how to correct (arch/arm/cpu/armv7/start.S:179:
>>> >> undefined reference to `relocate_done')
>>> >
>>> > Thansk Simon.
>>> >
>>> > In file arch/arm/cpu/armv7/start.S, line 179 uses relocate_done and
>>> > line 228 provides it, and there is no preprocessor conditional
>>> > in-between, so I fail to see how you could get this error.
>>> >
>>> > Is your tree (and branch) available so that I can try and see the issue
>>> > for myself? Either it'll uncover a problem in my patch series, or it'll
>>> > help you merge it (or both).
>>>
>>> OK I will try a bit harder and come back to you. Sorry I can't do that
>>> immediately but will be soon...
>>
>> Did you manage to reproduce or sort out this issue?
>
> No, I was hoping that I would be able to test upstream U-Boot on snow
> (waiting on some memory patches to appear), but that hasn't happened.
> I will have another go at working out the problem - either this week
> or next depending on when I can set aside the time for it. However,
> please don't hold up the series for it.

I have tested this on snow at last. My problem was basically the
distance between our tree and upstream - we are just coming up to a
rebase so are at the furthest point.

Tested-by: Simon Glass <sjg@chromium.org>
Acked-by: Simon Glass <sjg@chromium.org>

>
>>
>>> Regards,
>>> Simon
>>
>> Amicalement,
>> --
>> Albert.
>
> Regards,
> Simon