From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anatolij Gustschin Date: Sun, 4 Nov 2012 17:49:24 +0100 Subject: [U-Boot] [PATCH V2 3/4] lcd: calculate line_length after lcd_ctrl_init() In-Reply-To: <1350622294-374-3-git-send-email-swarren@wwwdotorg.org> References: <1350622294-374-1-git-send-email-swarren@wwwdotorg.org> <1350622294-374-3-git-send-email-swarren@wwwdotorg.org> Message-ID: <20121104174924.653c2264@wker> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi, On Thu, 18 Oct 2012 22:51:33 -0600 Stephen Warren wrote: > When an LCD driver is actually driving a regular external display, e.g. > an HDMI monitor, the display resolution might not be known until the > display controller has initialized, i.e. during lcd_ctrl_init(). However, > lcd.c calculates lcd_line_length before calling this function, thus > relying on a hard-coded resolution in struct panel_info. > > Instead, defer this calculation until after lcd_ctrl_init() has had the > chance to dynamically determine the resolution. This needs to happen > before lcd_clear(), since the value is used there. > > grep indicates that no code outside lcd.c uses this lcd_line_length; in > particular, no lcd_ctrl_init() implementations read it. > > Signed-off-by: Stephen Warren > --- > common/lcd.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Acked-by: Anatolij Gustschin Thanks, Anatolij