From mboxrd@z Thu Jan  1 00:00:00 1970
From: Albert ARIBAUD <albert.u.boot@aribaud.net>
Date: Sun, 4 Nov 2012 19:01:26 +0100
Subject: [U-Boot] [PATCH v2 1/2] arm: move C runtime setup code in crt0.S
In-Reply-To: <50968466.1050507@gmail.com>
References: <1352001421-25913-1-git-send-email-albert.u.boot@aribaud.net>
	<1352028725-26683-1-git-send-email-albert.u.boot@aribaud.net>
	<1352028725-26683-2-git-send-email-albert.u.boot@aribaud.net>
	<50968466.1050507@gmail.com>
Message-ID: <20121104190126.2372a6a9@lilith>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Vikram,

On Sun, 04 Nov 2012 20:36:14 +0530, Vikram Narayanan
<vikram186@gmail.com> wrote:

> Hello Albert,

> > diff --git a/arch/arm/lib/crt0.S b/arch/arm/lib/crt0.S

> > +#ifndef CONFIG_SPL_BUILD
> 
> In some places the other style is used. "!(defined)".
> Any particular reasons for switching b/w these two styles?

None except heterogeneity. In V3 I'll make sure 'defined()' is used
everywhere in the new files or added code.

> > +	ldr	r0, =__bss_start	/* this is auto-relocated! */
> > +	ldr	r1, =__bss_end__	/* this is aotu-relocated! */
> 
> s/aotu/auto

Thanks for spotting this. Will fix in V3.

> Regards,
> Vikram

Amicalement,
-- 
Albert.