public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Rommel G Custodio <sessyargc@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/3] mmc: sdhci: add the DMA select for SDMA
Date: Mon, 5 Nov 2012 22:39:14 +0900	[thread overview]
Message-ID: <20121105133827.GA62571@crg> (raw)
In-Reply-To: <505C09DB.20403@samsung.com>

Dear All, Jaehoon Chung

On 2012.09/21, Jaehoon Chung wrote:
> In host-control register, DMA select bit field is present.
> BUt in sdhci.c, didn't select for DMA.

This is an FYI.
Maybe others will encounter the same problem I had.

This code has recently been mainlined and it has caused some problems in
the IP that I am working with. The IP hangs when this code is enabled.

> if set CONFIG_MMC_SDMA, we need to set SDMA-select bit.

The bit in the SDHCI specs show that 00b is the code for choosing SDMA.
So this code is not really necessary as long as sdhci_init() or sdhci_set_ios(),
the API that modifies SDHCI_HOST_CONTROL, does not touch the DMA bits. Right now,
by looking at the code, sdhci_init() nor sdhci_set_ios() does not modify the DMA
bits.

> 
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>

All the best,
Rommel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 487 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20121105/e91d44c7/attachment.pgp>

  reply	other threads:[~2012-11-05 13:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-21  6:31 [U-Boot] [PATCH 2/3] mmc: sdhci: add the DMA select for SDMA Jaehoon Chung
2012-11-05 13:39 ` Rommel G Custodio [this message]
2012-11-06  0:31   ` Jaehoon Chung
2012-11-06 22:41     ` Rommel Custodio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121105133827.GA62571@crg \
    --to=sessyargc@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox