public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] serial: Remove the "serial" console device
Date: Tue, 6 Nov 2012 00:55:24 +0100	[thread overview]
Message-ID: <201211060055.24817.marex@denx.de> (raw)
In-Reply-To: <CANr=Z=a-WSDVD1A=N9WrK1vmYpXkcSPGonf211eAWWNN00VRfw@mail.gmail.com>

Dear Joe Hershberger,

> Hi Marek,
> 
> On Mon, Nov 5, 2012 at 5:11 PM, Marek Vasut <marex@denx.de> wrote:
> > Dear Joe Hershberger,
> > 
> >> Hi Marek,
> >> 
> >> On Fri, Nov 2, 2012 at 8:35 PM, Marek Vasut <marex@denx.de> wrote:
> >> > Dear Joe Hershberger,
> >> > 
> >> >> Each serial device is added as a console device.  There was also the
> >> >> "serial" device that points to the most-recently-assigned-to-some-
> >> >> console-handle device.  This can be confusing.  Instead, only show
> >> >> the actual serial devices.
> >> >> 
> >> >> Signed-off-by: Joe Hershberger <joe.hershberger@ni.com>
> >> >> ---
> >> >> 
> >> >>  common/console.c | 37 +++++++++++++++++++------------------
> >> >>  common/stdio.c   | 12 +-----------
> >> >>  2 files changed, 20 insertions(+), 29 deletions(-)
> >> > 
> >> > [...]
> >> > 
> >> > You also remove the nulldev, shouldn't it go via separate patch? ...
> >> > but otherwise it's good.
> >> 
> >> I'm not sure what you mean.  Where in this patch do I remove nulldev?
> >> That's the next patch.
> > 
> > The adjustment in common/stdio.c
> 
> I think you are reading the diff wrong.  The only nulldev related
> "change" is to not get warnings due to a (now) unused variable.  It
> simply guards the definition of the variable with the NULLDEV #ifdef.

Ok

Best regards,
Marek Vasut

      reply	other threads:[~2012-11-05 23:55 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-01 21:46 [U-Boot] [PATCH 1/2] serial: Remove the "serial" console device Joe Hershberger
2012-11-01 21:46 ` [U-Boot] [PATCH 2/2] serial: Make nulldev a serial device Joe Hershberger
2012-11-03  1:37   ` Marek Vasut
2012-11-05  0:24     ` Joe Hershberger
2012-11-05 23:10       ` Marek Vasut
2012-11-06  0:01         ` Joe Hershberger
2012-11-06  0:47           ` Marek Vasut
2012-11-06  1:00             ` Joe Hershberger
2012-11-06  1:11               ` Marek Vasut
2012-11-03  1:35 ` [U-Boot] [PATCH 1/2] serial: Remove the "serial" console device Marek Vasut
2012-11-05  0:20   ` Joe Hershberger
2012-11-05 23:11     ` Marek Vasut
2012-11-05 23:45       ` Joe Hershberger
2012-11-05 23:55         ` Marek Vasut [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201211060055.24817.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox