[U-Boot] [PATCH 1/2] serial: Remove the "serial" console device

Marek Vasut
2012-11-05T23:55:24Z

> Hi Marek,
>
> On Mon, Nov 5, 2012 at 5:11 PM, Marek Vasut <marex@denx.de> wrote:
> > Dear Joe Hershberger,
> >
> >> Hi Marek,
> >>
> >> On Fri, Nov 2, 2012 at 8:35 PM, Marek Vasut <marex@denx.de> wrote:
> >> > Dear Joe Hershberger,
> >> >
> >> >> Each serial device is added as a console device. There was also the
> >> >> "serial" device that points to the most-recently-assigned-to-some-
> >> >> console-handle device. This can be confusing. Instead, only show
> >> >> the actual serial devices.
> >> >>
> >> >> Signed-off-by: Joe Hershberger <joe.hershberger@ni.com>
> >> >> ---
> >> >>
> >> >> common/console.c | 37 +++++++++++++++++++------------------
> >> >> common/stdio.c | 12 +-----------
> >> >> 2 files changed, 20 insertions(+), 29 deletions(-)
> >> >
> >> > [...]
> >> >
> >> > You also remove the nulldev, shouldn't it go via separate patch? ...
> >> > but otherwise it's good.
> >>
> >> I'm not sure what you mean. Where in this patch do I remove nulldev?
> >> That's the next patch.
> >
> > The adjustment in common/stdio.c
>
> I think you are reading the diff wrong. The only nulldev related
> "change" is to not get warnings due to a (now) unused variable. It
> simply guards the definition of the variable with the NULLDEV #ifdef.

Ok

Best regards,
Marek Vasut