public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Lukasz Majewski <l.majewski@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] USB mass storage gadget patch
Date: Tue, 06 Nov 2012 10:03:43 +0100	[thread overview]
Message-ID: <20121106100343.3db7cc1a@amdc308.digital.local> (raw)
In-Reply-To: <019901cdbbea$73d9b000$5b8d1000$@keyasic.com>

Hi victor,

Regarding UMS support:

The last version posted at u-boot ML can be found at [**]:
http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/113004/match=ums



I've go through your fixes for file_storage.c. 


Please find appended diff file [*] for changes which I was able to
apply on the original file_storage.c file (taken from [**]).

I've attached output from Host dmesg and target's console (output.txt)

It seems that on my setup your patches are causing errors and UMS is
not working (e.g. partitions aren't exported).

I don't have enough time now to delve to your solution, but I'm
skeptical about hard setting EPs (like below).

+if (fsg_fs_bulk_out_desc.bEndpointAddress != 0x1)
+	fsg_fs_bulk_out_desc.bEndpointAddress = 0x1;
+

If possible, please align to patch set [**], so we can have the same
setup.

However, I will try to find some time to help you with the problem
(that's why I've asked for description of the problem, which you are
trying to fix).

-- 
Best regards,

Lukasz Majewski

Samsung Poland R&D Center | Linux Platform Group
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-UMS-CHanges-made-by-Victor-applied-to-UMS_v2-file-ap.patch
Type: text/x-patch
Size: 83556 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20121106/6d847b5e/attachment.bin>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: output.txt
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20121106/6d847b5e/attachment.txt>

  reply	other threads:[~2012-11-06  9:03 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-02 11:07 [U-Boot] USB mass storage gadget patch victor
2012-11-02 13:19 ` Lukasz Majewski
2012-11-05  2:30   ` victor
2012-11-05  6:45   ` victor
2012-11-06  6:46   ` victor
2012-11-06  9:03     ` Lukasz Majewski [this message]
2012-11-06  9:58       ` victor
2012-11-06 11:08       ` victor
2012-11-22  2:24       ` victor
  -- strict thread matches above, loose matches on Subject: below --
2012-11-02 11:43 victor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121106100343.3db7cc1a@amdc308.digital.local \
    --to=l.majewski@samsung.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox