From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] USB: add arrow key support to usb_kbd
Date: Tue, 6 Nov 2012 23:56:37 +0100 [thread overview]
Message-ID: <201211062356.37374.marex@denx.de> (raw)
In-Reply-To: <CAPnjgZ2y4F5aQSj=xXi_-d-8OSmn5+roM+oatvtrq59Y_=3MCA@mail.gmail.com>
Dear Simon Glass,
> Hi Marek,
>
> On Tue, Nov 6, 2012 at 2:49 PM, Marek Vasut <marex@denx.de> wrote:
> > Dear Allen Martin,
> >
> >> Check for scancodes for arrow keys and map them to ^F/^B, ^N/^P.
> >> Control characters are used instead of ANSI sequence because the
> >> queueing code in usb_kbd doesn't handle the data increase when one
> >> keypress generates 3 keycodes. The real fix is to convert this driver
> >> to use the input subsystem and queue
> >
> > If it's the real fix, then why not go for the real fix right away? :-(
>
> Because it's a fair chunk of work
Let's either do it properly or not at all ... if I let you do these semi-
complete fixes, we'll end up with a stinking pile of crap like windows ...
> and also if we are doing USB we
> should probably do keyboard.c first.
Uh, I don't follow.
> USB would not be the first
> priority since so much of the logic / keycodes are different.
Sorry, I'm completely lost.
> Regards,
> Simon
>
> >> but this allows arrow keys to
> >> work until this driver is converted.
> >>
> >> Signed-off-by: Allen Martin <amartin@nvidia.com>
> >> ---
> >
> > [...]
> >
> > Best regards,
> > Marek Vasut
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-11-06 22:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-06 21:26 [U-Boot] [PATCH] USB: add arrow key support to usb_kbd Allen Martin
2012-11-06 21:51 ` Stephen Warren
2012-11-06 22:49 ` Marek Vasut
2012-11-06 22:51 ` Simon Glass
2012-11-06 22:56 ` Marek Vasut [this message]
2012-11-06 23:06 ` Allen Martin
2012-11-07 13:15 ` Marek Vasut
2012-11-06 23:09 ` Stephen Warren
2012-11-07 13:18 ` Marek Vasut
2012-11-07 19:02 ` Allen Martin
2012-11-08 1:19 ` Marek Vasut
2012-11-06 22:55 ` Allen Martin
2012-11-06 22:52 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201211062356.37374.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox