From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] common/command.c: revert chanches from commit 199adb60
Date: Sat, 10 Nov 2012 12:21:55 +0100 [thread overview]
Message-ID: <20121110122155.369669be@lilith> (raw)
In-Reply-To: <20121108134214.71ccf032@wker>
Hi Anatolij,
On Thu, 8 Nov 2012 13:42:14 +0100, Anatolij Gustschin <agust@denx.de>
wrote:
> On Thu, 8 Nov 2012 12:52:13 +0100
> Anatolij Gustschin <agust@denx.de> wrote:
>
> > commit 199adb601ff34bdbbd0667fac80dfe0a87bffc2b "common/misc: sparse
> > fixes" broke the help command trying to fix the sparse error
> > "command.c:44:38: error: bad constant expression".
> >
> > As Henrik points out, the fix was bad because the commit used
> > CONFIG_SYS_MAXARGS whereas the code intended to use the maximum
> > number of commands (not arguments to a command).
> >
> > Revert command.c changes to the original code as asked by Wolfgang.
> >
> > Reported-by: Henrik Nordstr?m <henrik@henriknordstrom.net>
> > Signed-off-by: Anatolij Gustschin <agust@denx.de>
> > ---
> > common/command.c | 9 +--------
> > 1 files changed, 1 insertions(+), 8 deletions(-)
>
> Applied to u-boot-staging/agust at denx.de-urgent.
Did you fix the typo in the commit summary/subject on the fly?
Amicalement,
--
Albert.
next prev parent reply other threads:[~2012-11-10 11:21 UTC|newest]
Thread overview: 117+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-17 0:28 [U-Boot] [PATCH 00/32] Initial sparse fix series Kim Phillips
2012-10-17 0:28 ` [U-Boot] [PATCH 01/32] include/linux/byteorder: import latest endian definitions from linux Kim Phillips
2012-10-25 17:37 ` Tom Rini
2012-10-17 0:28 ` [U-Boot] [PATCH 02/32] include/linux/compat.h: fix warning: preprocessor token __iomem redefined Kim Phillips
2012-10-24 21:31 ` Tom Rini
2012-10-17 0:28 ` [U-Boot] [PATCH 03/32] include/linux/unaligned/generic.h: fix warning: preprocessor token __force redefined Kim Phillips
2012-10-17 0:28 ` [U-Boot] [PATCH 04/32] include/linux/stddef.h: avoid 'warning: preprocessor token offsetof redefined' Kim Phillips
2012-10-17 0:28 ` [U-Boot] [PATCH 05/32] arch/powerpc/include/asm/io.h: fix warning: preprocessor token __iomem redefined Kim Phillips
2012-10-17 0:28 ` [U-Boot] [PATCH 06/32] arch/powerpc/lib/bootm.c: fix noinline attribute Kim Phillips
2012-10-17 0:28 ` [U-Boot] [PATCH 07/32] arch/powerpc/lib/extable.c: sparse fix Kim Phillips
2012-10-17 0:28 ` [U-Boot] [PATCH 08/32] arch/powerpc/lib/board.c, *traps.c: sparse fixes Kim Phillips
2012-10-18 16:55 ` Tom Rini
2012-10-17 0:28 ` [U-Boot] [PATCH 09/32] include/common.h: sparse fix Kim Phillips
2012-10-17 0:28 ` [U-Boot] [PATCH 10/32] include/command.h: " Kim Phillips
2012-10-25 16:35 ` Tom Rini
2012-10-17 0:28 ` [U-Boot] [PATCH 11/32] include/image.h: sparse fixes Kim Phillips
2012-10-17 0:28 ` [U-Boot] [PATCH 12/32] common/cmd_*.c: " Kim Phillips
2012-10-24 23:49 ` Tom Rini
2012-10-17 0:28 ` [U-Boot] [PATCH 13/32] common/misc: " Kim Phillips
2012-10-25 17:32 ` Tom Rini
2012-10-17 0:28 ` [U-Boot] [PATCH 14/32] common/fdt_support.c: " Kim Phillips
2012-10-17 0:28 ` [U-Boot] [PATCH 15/32] net/: " Kim Phillips
2012-10-17 0:28 ` [U-Boot] [PATCH 16/32] drivers/net/: " Kim Phillips
2012-10-17 0:28 ` [U-Boot] [PATCH 17/32] lib/zlib: " Kim Phillips
2012-10-17 0:28 ` [U-Boot] [PATCH 18/32] lib/vsprintf.c: " Kim Phillips
2012-10-17 0:28 ` [U-Boot] [PATCH 19/32] include/fdt.h: " Kim Phillips
2012-10-17 0:28 ` [U-Boot] [PATCH 20/32] arch/powerpc/cpu/mpc8xxx/: " Kim Phillips
2012-10-17 0:28 ` [U-Boot] [PATCH 21/32] arch/powerpc/cpu/mpc85xx/fdt.c: " Kim Phillips
2012-10-17 0:28 ` [U-Boot] [PATCH 22/32] powerpc/mpc85xx: " Kim Phillips
2012-10-17 0:28 ` [U-Boot] [PATCH 23/32] powerpc/mpc83xx: " Kim Phillips
2012-10-17 0:28 ` [U-Boot] [PATCH 24/32] drivers/block/: " Kim Phillips
2012-10-17 0:28 ` [U-Boot] [PATCH 25/32] drivers/gpio/mpc83xx_gpio.c: " Kim Phillips
2012-10-17 0:28 ` [U-Boot] [PATCH 26/32] drivers/input/input.c: sparse fix Kim Phillips
2012-10-17 0:28 ` [U-Boot] [PATCH 27/32] drivers/i2c/fsl_i2c.c: " Kim Phillips
2012-10-17 3:57 ` Heiko Schocher
2012-10-26 3:29 ` [U-Boot] [U-Boot,27/32] " Tom Rini
2012-10-17 0:28 ` [U-Boot] [PATCH 28/32] drivers/mmc/mmc.c: sparse fixes Kim Phillips
2012-10-17 0:28 ` [U-Boot] [PATCH 29/32] drivers/mmc/fsl_esdhc.c: " Kim Phillips
2012-10-17 0:28 ` [U-Boot] [PATCH 30/32] drivers/mtd/cfi_flash.c: " Kim Phillips
2012-10-17 0:28 ` [U-Boot] [PATCH 31/32] drivers/mtd/nand: " Kim Phillips
2012-10-22 19:18 ` Scott Wood
2012-10-17 0:28 ` [U-Boot] [PATCH 32/32] drivers/serial/serial_ns16550.c: " Kim Phillips
2012-10-26 3:30 ` [U-Boot] [U-Boot, " Tom Rini
2012-10-18 0:19 ` [U-Boot] [PATCH 00/32] Initial sparse fix series Jerry Van Baren
2012-10-18 12:11 ` David Gibson
2012-10-18 22:30 ` Kim Phillips
2012-10-19 0:43 ` David Gibson
2012-10-30 21:57 ` [U-Boot] [PATCH] libfdt: introduce fdt type annotation for use by endian checkers Kim Phillips
2012-10-30 22:24 ` Stephen Warren
2012-10-30 22:27 ` Kim Phillips
2012-11-06 7:48 ` David Gibson
2012-11-14 0:34 ` [U-Boot] [PATCH 3/4 v2] dtc/libfdt: introduce fdt types for annotation " Kim Phillips
2012-11-14 14:42 ` Jon Loeliger
2012-11-15 0:59 ` [U-Boot] [PATCH v2 1/4] dtc/tests: don't include fdt.h prior to libfdt.h Kim Phillips
2012-11-15 0:59 ` [U-Boot] [PATCH v2 2/4] dtc/fdtdump: include libfdt_env.h prior to fdt.h Kim Phillips
2012-11-15 0:59 ` [U-Boot] [PATCH v3 3/4] dtc/libfdt: introduce fdt types for annotation by endian checkers Kim Phillips
2012-11-15 4:43 ` David Gibson
2012-11-15 5:12 ` Kim Phillips
2012-11-19 2:30 ` David Gibson
2012-11-28 23:33 ` [U-Boot] [PATCH v4 " Kim Phillips
2012-12-03 4:05 ` David Gibson
2013-01-06 21:52 ` Jon Loeliger
2012-11-15 0:59 ` [U-Boot] [PATCH v2 4/4] dtc/libfdt: uintXX_t to fdtXX_t conversion Kim Phillips
2012-10-18 16:53 ` [U-Boot] [PATCH 00/32] Initial sparse fix series Tom Rini
2012-10-24 21:21 ` Tom Rini
2012-10-24 22:47 ` Kim Phillips
2012-10-25 17:46 ` Tom Rini
2012-10-25 18:59 ` Kim Phillips
2012-10-25 19:28 ` Tom Rini
2012-10-29 23:34 ` [U-Boot] [PATCH v2 " Kim Phillips
2012-10-29 23:34 ` [U-Boot] [PATCH v2 01/25] include/linux/byteorder: import latest endian definitions from linux Kim Phillips
2012-10-29 23:34 ` [U-Boot] [PATCH v2 02/25] include/linux/compat.h: fix warning: preprocessor token {__iomem, __user} redefined Kim Phillips
2012-10-29 23:34 ` [U-Boot] [PATCH v2 03/25] include/linux/unaligned/generic.h: fix warning: preprocessor token __force redefined Kim Phillips
2012-10-29 23:34 ` [U-Boot] [PATCH v2 04/25] include/linux/stddef.h: avoid 'warning: preprocessor token offsetof redefined' Kim Phillips
2012-10-29 23:34 ` [U-Boot] [PATCH v2 05/25] arch/powerpc/include/asm/io.h: fix warning: preprocessor token __iomem redefined Kim Phillips
2012-10-29 23:34 ` [U-Boot] [PATCH v2 06/25] arch/powerpc/lib/extable.c: sparse fix Kim Phillips
2012-10-29 23:34 ` [U-Boot] [PATCH v2 07/25] arch/powerpc/lib/board.c, *traps.c: sparse fixes Kim Phillips
2012-10-29 23:34 ` [U-Boot] [PATCH v2 08/25] include/image.h: " Kim Phillips
2012-10-29 23:34 ` [U-Boot] [PATCH v2 09/25] common/cmd_*.c: " Kim Phillips
2012-11-08 10:48 ` Wolfgang Denk
2012-11-09 1:04 ` Kim Phillips
2012-10-29 23:34 ` [U-Boot] [PATCH v2 10/25] common/misc: " Kim Phillips
2012-11-05 21:30 ` Henrik Nordström
2012-11-06 1:51 ` [U-Boot] [PATCH] common: fix help command breakage Kim Phillips
2012-11-06 5:44 ` Henrik Nordström
2012-11-07 21:39 ` Simon Glass
2012-11-07 22:23 ` Anatolij Gustschin
2012-11-08 11:02 ` Anatolij Gustschin
2012-11-08 11:23 ` Wolfgang Denk
2012-11-08 10:41 ` Wolfgang Denk
2012-11-08 11:52 ` [U-Boot] [PATCH] common/command.c: revert chanches from commit 199adb60 Anatolij Gustschin
2012-11-08 12:42 ` Anatolij Gustschin
2012-11-10 11:21 ` Albert ARIBAUD [this message]
2012-11-10 11:41 ` Anatolij Gustschin
2012-12-14 4:13 ` Rommel Custodio
2012-12-14 7:51 ` Anatolij Gustschin
2012-10-29 23:34 ` [U-Boot] [PATCH v2 11/25] net/: sparse fixes Kim Phillips
2012-10-29 23:34 ` [U-Boot] [PATCH v2 12/25] drivers/net/: " Kim Phillips
2012-10-29 23:34 ` [U-Boot] [PATCH v2 13/25] lib/zlib: " Kim Phillips
2012-11-08 11:20 ` Wolfgang Denk
2012-11-09 1:06 ` Kim Phillips
2012-11-21 16:37 ` Tom Rini
2012-10-29 23:34 ` [U-Boot] [PATCH v2 14/25] lib/vsprintf.c: " Kim Phillips
2012-10-29 23:34 ` [U-Boot] [PATCH v2 15/25] arch/powerpc/cpu/mpc8xxx/: " Kim Phillips
2012-10-29 23:34 ` [U-Boot] [PATCH v2 16/25] powerpc/mpc85xx: " Kim Phillips
2012-10-29 23:34 ` [U-Boot] [PATCH v2 17/25] powerpc/mpc83xx: " Kim Phillips
2012-10-29 23:34 ` [U-Boot] [PATCH v2 18/25] drivers/block/: " Kim Phillips
2012-10-29 23:34 ` [U-Boot] [PATCH v2 19/25] drivers/gpio/mpc83xx_gpio.c: " Kim Phillips
2012-10-29 23:34 ` [U-Boot] [PATCH v2 20/25] drivers/input/input.c: sparse fix Kim Phillips
2012-10-31 5:51 ` Simon Glass
2012-10-29 23:34 ` [U-Boot] [PATCH v2 21/25] drivers/mmc/mmc.c: sparse fixes Kim Phillips
2012-10-29 23:34 ` [U-Boot] [PATCH v2 22/25] drivers/mmc/fsl_esdhc.c: " Kim Phillips
2012-10-29 23:34 ` [U-Boot] [PATCH v2 23/25] drivers/mtd/cfi_flash.c: " Kim Phillips
2012-10-29 23:34 ` [U-Boot] [PATCH v2 24/25] drivers/mtd/nand: " Kim Phillips
2012-10-30 0:43 ` Scott Wood
2012-10-29 23:34 ` [U-Boot] [PATCH v2 25/25] drivers/serial/serial_ns16550.c: " Kim Phillips
2012-11-04 18:30 ` [U-Boot] [PATCH v2 00/32] Initial sparse fix series Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121110122155.369669be@lilith \
--to=albert.u.boot@aribaud.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox