From mboxrd@z Thu Jan 1 00:00:00 1970 From: Albert ARIBAUD Date: Sat, 10 Nov 2012 12:21:55 +0100 Subject: [U-Boot] [PATCH] common/command.c: revert chanches from commit 199adb60 In-Reply-To: <20121108134214.71ccf032@wker> References: <20121105195111.8a326673862d0552354e2815@freescale.com> <1352375533-32145-1-git-send-email-agust@denx.de> <20121108134214.71ccf032@wker> Message-ID: <20121110122155.369669be@lilith> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Anatolij, On Thu, 8 Nov 2012 13:42:14 +0100, Anatolij Gustschin wrote: > On Thu, 8 Nov 2012 12:52:13 +0100 > Anatolij Gustschin wrote: > > > commit 199adb601ff34bdbbd0667fac80dfe0a87bffc2b "common/misc: sparse > > fixes" broke the help command trying to fix the sparse error > > "command.c:44:38: error: bad constant expression". > > > > As Henrik points out, the fix was bad because the commit used > > CONFIG_SYS_MAXARGS whereas the code intended to use the maximum > > number of commands (not arguments to a command). > > > > Revert command.c changes to the original code as asked by Wolfgang. > > > > Reported-by: Henrik Nordstr?m > > Signed-off-by: Anatolij Gustschin > > --- > > common/command.c | 9 +-------- > > 1 files changed, 1 insertions(+), 8 deletions(-) > > Applied to u-boot-staging/agust at denx.de-urgent. Did you fix the typo in the commit summary/subject on the fly? Amicalement, -- Albert.