[U-Boot] [PATCH v2 13/25] lib/zlib: sparse fixes

Wolfgang Denk
2012-11-08T11:20:51Z

Dear Kim Phillips,

In message <1351553687-12469-14-git-send-email-kim.phillips@freescale.com> you wrote:
> define Z_NULL to (void *)0 include/u-boot/zlib.h to get rid of most of
> the NULL pointer warnings.
...
> -#define Z_NULL 0 /* for initializing zalloc, zfree, opaque */
> +#define Z_NULL (void *)0 /* for initializing zalloc, zfree, opaque */

Don't we have to put parens around such an expression?

> --- a/lib/zlib/adler32.c
> +++ b/lib/zlib/adler32.c
> @@ -54,10 +54,7 @@
> #endif
>
> /* ========================================================================= */
> -uLong ZEXPORT adler32(adler, buf, len)
> - uLong adler;
> - const Bytef *buf;
> - uInt len;
> +uLong ZEXPORT adler32(uLong adler, const Bytef *buf, uInt len)

Hm... this code has been imported from another project. This
modification makes updates (or even comparing what has changed in more
recent versions) much mor difficult, or even impossible
:-(

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I have a very small mind and must live with it. -- Edsger Dijkstra