[U-Boot] [PATCH v2 09/25] common/cmd_*.c: sparse fixes

Wolfgang Denk
2012-11-08T10:48:54Z

Dear Kim Phillips,

In message <1351553687-12469-10-git-send-email-kim.phillips@freescale.com> you wrote:
>
...
> Signed-off-by: Kim Phillips <kim.phillips@freescale.com>

Has anybody tested the impact of this change on the memory
footprint?

I object against the implementation.

The whole idea of the U_BOOT_CMD() macro was to be able to write
command entries in a _convenient_ way. This patch makes this worse.

Please fix this such that we do NOT have to do all this ugly manual
encoding of the help texts.

Note also that this patch implements quite a few pretty much
different changes - these should be split into separate commits.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
When it is incorrect, it is, at least *authoritatively* incorrect.
- Hitchiker's Guide To The Galaxy