public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 0/2] Factorize ARM startup code as mush as possible.
Date: Sat, 10 Nov 2012 15:30:04 +0100	[thread overview]
Message-ID: <20121110153004.7fd0f923@lilith> (raw)
In-Reply-To: <20121108142028.GA5738@Hardy>

Hi Sughosh,

On Thu, 8 Nov 2012 19:50:28 +0530, Sughosh Ganu
<urwithsughosh@gmail.com> wrote:

> hi Albert,
> 
> On Mon Nov 05, 2012 at 01:09:25PM +0530, Sughosh Ganu wrote:
> > On Sun Nov 04, 2012 at 10:38:32AM -0700, Tom Rini wrote:
> > > On Sun, Nov 04, 2012 at 12:43:12PM +0100, Albert ARIBAUD wrote:
> > > 
> > > > Hi Tom,
> > > > 
> > > > On Sun,  4 Nov 2012 12:32:03 +0100, Albert ARIBAUD
> > > > <albert.u.boot@aribaud.net> wrote:
> > > > 
> > > > > The goal of this series is to scrub the start.S files
> > > > > which have proliferated across arch/arm and eliminate
> > > > > code redundancy.
> > > > 
> > > > I know this came a bit late in early nov 4th, but I really would like
> > > > it to be considered for 2013.01. Would you agree to make an exception
> > > > for it? Thanks in advance.
> > > 
> > > If you can collect a diverse set of Tested-by's, yes.
> > 
> > I have not gone through the patch, but will test it in a day or two on
> > the hawkboard, and report the findings.
> > 
> > The hawkboard comes with the arm926ejs core, so that part of the code
> > would be tested.
> 
> I tried the 1st patch of the series, and with that u-boot does not
> come up on the board. It is also printing out some random values for
> the dram and nand sizes.
> 
> The patch was applied on top of commit 1cc619be8b7. Also, with the
> mentioned commit, u-boot boots up fine on the board. Also to be noted
> is that the spl image compiled with these changes is booting up fine,
> loading the main u-boot image, and jumping to it -- the issue is with
> booting the main u-boot image.

Thanks Sughosh. Can you build an U-Boot with the following defined
in the hawkboard.h config file?

#define DEBUG
#if defined(CONFIG_SPL_BUILD) && ! defined (__ASSEMBLY__)
static inline int printf(const char *fmt, ...)
{
        return 0;
}
#endif

Note: only the #define DEBUG matter to me, but with it alone, SPL build
fails due to some code now requiring printf(). This is why I add a
dummy printf definition for C code during SPL build -- ASM code does not
need printf() and actually chokes on the definition, hence the
condition on __ASSEMBLY__.

This debug U-Boot should print a lot more info. Can you please try it
and copy/paste its output here? Thanks in advance.

Amicalement,
-- 
Albert.

  reply	other threads:[~2012-11-10 14:30 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-04  3:57 [U-Boot] [PATCH v1 0/1] Factorize ARM startup code as mush as possible Albert ARIBAUD
2012-11-04  3:57 ` [U-Boot] [PATCH v1] arm: move generic startup code in crt0.S Albert ARIBAUD
2012-11-04  7:29   ` Wolfgang Denk
2012-11-04  8:36     ` Albert ARIBAUD
2012-11-04 11:32 ` [U-Boot] [PATCH v2 0/2] Factorize ARM startup code as mush as possible Albert ARIBAUD
2012-11-04 11:32   ` [U-Boot] [PATCH v2 1/2] arm: move C runtime setup code in crt0.S Albert ARIBAUD
2012-11-04 11:32     ` [U-Boot] [PATCH v2 2/2] arm: remove useless code in start.S files Albert ARIBAUD
2012-11-04 11:34     ` [U-Boot] [PATCH v2 1/2] arm: move C runtime setup code in crt0.S Albert ARIBAUD
2012-11-04 15:06     ` Vikram Narayanan
2012-11-04 18:01       ` Albert ARIBAUD
2012-11-05  8:31     ` Andreas Bießmann
2012-11-10 16:48       ` Albert ARIBAUD
2012-11-10 16:53     ` Albert ARIBAUD
2012-11-04 11:43   ` [U-Boot] [PATCH v2 0/2] Factorize ARM startup code as mush as possible Albert ARIBAUD
2012-11-04 17:38     ` Tom Rini
2012-11-05  7:39       ` Sughosh Ganu
2012-11-08 14:20         ` Sughosh Ganu
2012-11-10 14:30           ` Albert ARIBAUD [this message]
2012-11-13  4:10             ` Sughosh Ganu
2012-11-13 19:55               ` Albert ARIBAUD
2012-12-09 20:31                 ` Sughosh Ganu
2012-11-10 17:00   ` [U-Boot] [PATCH v3 " Albert ARIBAUD
2012-11-10 17:00     ` [U-Boot] [PATCH v3 1/2] arm: move C runtime setup code in crt0.S Albert ARIBAUD
2012-11-10 17:00       ` [U-Boot] [PATCH v3 2/2] arm: remove useless code in start.S files Albert ARIBAUD
2012-11-15 19:35       ` [U-Boot] [PATCH v3 1/2] arm: move C runtime setup code in crt0.S Simon Glass
2012-11-15 22:41         ` Albert ARIBAUD
2012-11-10 17:28     ` [U-Boot] [PATCH v3 0/2] Factorize ARM startup code as mush as possible Albert ARIBAUD
2012-11-27 12:43     ` [U-Boot] [PATCH v4 " Albert ARIBAUD
2012-11-27 12:43       ` [U-Boot] [PATCH v4 1/2] arm: move C runtime setup code in crt0.S Albert ARIBAUD
2012-11-27 12:43         ` [U-Boot] [PATCH v4 2/2] arm: remove useless code in start.S files Albert ARIBAUD
2013-01-07 14:41           ` Tom Rini
2012-11-28 21:18         ` [U-Boot] [PATCH v4 1/2] arm: move C runtime setup code in crt0.S Simon Glass
2012-11-28 22:34           ` Albert ARIBAUD
2012-11-30 22:10             ` Simon Glass
2012-12-23 15:03               ` Albert ARIBAUD
2012-12-26 20:41                 ` Simon Glass
2013-01-05  1:00                   ` Simon Glass
2012-12-09 20:33         ` Sughosh Ganu
2013-01-07 14:40         ` Tom Rini
2013-01-08 19:26         ` Tom Rini
2013-01-08 19:50           ` Albert ARIBAUD
2013-01-08 20:18         ` [U-Boot] [PATCH v5 0/2] Factorize ARM startup code as much as possible Albert ARIBAUD
2013-01-08 20:18           ` [U-Boot] [PATCH v5 1/2] arm: move C runtime setup code in crt0.S Albert ARIBAUD
2013-01-08 20:18             ` [U-Boot] [PATCH v5 2/2] arm: remove useless code in start.S files Albert ARIBAUD
2013-01-08 21:16           ` [U-Boot] [PATCH v5 0/2] Factorize ARM startup code as much as possible Albert ARIBAUD
2012-12-27 11:27       ` [U-Boot] [PATCH v4 0/2] Factorize ARM startup code as mush " Albert ARIBAUD
2013-01-08 17:20       ` Albert ARIBAUD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121110153004.7fd0f923@lilith \
    --to=albert.u.boot@aribaud.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox