From mboxrd@z Thu Jan 1 00:00:00 1970 From: Albert ARIBAUD Date: Sat, 10 Nov 2012 17:48:41 +0100 Subject: [U-Boot] [PATCH v2 1/2] arm: move C runtime setup code in crt0.S In-Reply-To: <5097797B.4050904@gmail.com> References: <1352001421-25913-1-git-send-email-albert.u.boot@aribaud.net> <1352028725-26683-1-git-send-email-albert.u.boot@aribaud.net> <1352028725-26683-2-git-send-email-albert.u.boot@aribaud.net> <5097797B.4050904@gmail.com> Message-ID: <20121110174841.77dd20d5@lilith> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Andreas, On Mon, 05 Nov 2012 09:31:55 +0100, "Andreas Bie?mann" wrote: > Dear Albert Aribaud, > DDR means DRAM in general? Yes -- but DRAM is no better, as it still describes a technology (class). I'm going tu use "system RAM" to describe it. > > + * must use GD to store any data which must be passed on to later, > -----------------------------------------------------------------------^ Fixed. > > + * stages, including the reloction destination and the new stack > > + * pointer address, below which the stack resides and above it the > ------------------------^ > Full stop? The rest of the sentence makes no sense to me. Rewritten. > > +#if defined(CONFIG_NAND_SPL) > > + /* deprecated, use instead CONFIG_SPL_BUILD */ > I wonder if we can emit a #warning here Hmm... Will test and let people know how many boards stop compiling cleanly. > > +#ifdef CONFIG_SPL_BUILD > > I think this should be negated. The coloured LED stuff was enabled for > non SPL builds before! Correct. > > + > > + bl coloured_LED_init > > + bl red_led_on > > + > > +#endif > > + > > + /* call board_init_r(gd_t *id, ulong dest_addr) */ > Shouldn't this move down in the #elif path? Moved. > Best regards > > Andreas Bie?mann Thanks a lot for your review! Amicalement, -- Albert.