[U-Boot] [PATCH] nand_spl: fix u-boot.lst breakage

public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed

* [U-Boot] [PATCH] nand_spl: fix u-boot.lst breakage
@ 2012-11-13 22:30 Scott Wood
  2012-11-13 23:17 ` Marek Vasut
  2012-11-14 10:18 ` Anatolij Gustschin
  0 siblings, 2 replies; 4+ messages in thread
From: Scott Wood @ 2012-11-13 22:30 UTC (permalink / raw)
  To: u-boot

Commit 97b24d3d51a92cb8c0c1e1a74abf22fe1a1807a3 "common: Add symbol
handling for generic lists into Makefile" introduced build errors in many
nand_spl targets, complaining of a missing u-boot.lst.  When not doing an
out-of-tree build, $(obj) expands to nothing, so GCC ended up being given
-I with no argument (or rather, -ansi was the argument).  The failure
didn't show up during a -j1 build because it was picking up the non-SPL
version of u-boot.lst.

Signed-off-by: Scott Wood <scottwood@freescale.com>
---
I didn't fix p1_p2_rdb_pc because that will just conflict with the
patchset that migrates that target away from nand_spl.

 nand_spl/board/freescale/mpc8536ds/Makefile  |    3 ++-
 nand_spl/board/freescale/mpc8569mds/Makefile |    3 ++-
 nand_spl/board/freescale/mpc8572ds/Makefile  |    3 ++-
 nand_spl/board/freescale/mx31pdk/Makefile    |    3 ++-
 nand_spl/board/freescale/p1010rdb/Makefile   |    3 ++-
 nand_spl/board/freescale/p1023rds/Makefile   |    3 ++-
 nand_spl/board/freescale/p1_p2_rdb/Makefile  |    3 ++-
 nand_spl/board/karo/tx25/Makefile            |    3 ++-
 8 files changed, 16 insertions(+), 8 deletions(-)

diff --git a/nand_spl/board/freescale/mpc8536ds/Makefile b/nand_spl/board/freescale/mpc8536ds/Makefile
index c923557..9c77826 100644
--- a/nand_spl/board/freescale/mpc8536ds/Makefile
+++ b/nand_spl/board/freescale/mpc8536ds/Makefile
@@ -67,7 +67,8 @@ $(nandobj)u-boot-spl:	$(OBJS) $(nandobj)u-boot-nand_spl.lds
 # $(LDSCRIPT). The function make_u_boot_list is defined in helper.mk file.
 $(eval $(call make_u_boot_list, $(LSTSCRIPT), $(OBJS)))
 $(nandobj)u-boot-nand_spl.lds: $(LDSCRIPT) $(LSTSCRIPT)
-	$(CPP) $(CPPFLAGS) $(LDPPFLAGS) -I$(obj) -ansi -D__ASSEMBLY__ -P - <$< >$@
+	$(CPP) $(CPPFLAGS) $(LDPPFLAGS) -I$(nandobj)/board/$(BOARDDIR) \
+		-ansi -D__ASSEMBLY__ -P - <$< >$@
 
 # create symbolic links for common files
 
diff --git a/nand_spl/board/freescale/mpc8569mds/Makefile b/nand_spl/board/freescale/mpc8569mds/Makefile
index c923557..9c77826 100644
--- a/nand_spl/board/freescale/mpc8569mds/Makefile
+++ b/nand_spl/board/freescale/mpc8569mds/Makefile
@@ -67,7 +67,8 @@ $(nandobj)u-boot-spl:	$(OBJS) $(nandobj)u-boot-nand_spl.lds
 # $(LDSCRIPT). The function make_u_boot_list is defined in helper.mk file.
 $(eval $(call make_u_boot_list, $(LSTSCRIPT), $(OBJS)))
 $(nandobj)u-boot-nand_spl.lds: $(LDSCRIPT) $(LSTSCRIPT)
-	$(CPP) $(CPPFLAGS) $(LDPPFLAGS) -I$(obj) -ansi -D__ASSEMBLY__ -P - <$< >$@
+	$(CPP) $(CPPFLAGS) $(LDPPFLAGS) -I$(nandobj)/board/$(BOARDDIR) \
+		-ansi -D__ASSEMBLY__ -P - <$< >$@
 
 # create symbolic links for common files
 
diff --git a/nand_spl/board/freescale/mpc8572ds/Makefile b/nand_spl/board/freescale/mpc8572ds/Makefile
index c923557..9c77826 100644
--- a/nand_spl/board/freescale/mpc8572ds/Makefile
+++ b/nand_spl/board/freescale/mpc8572ds/Makefile
@@ -67,7 +67,8 @@ $(nandobj)u-boot-spl:	$(OBJS) $(nandobj)u-boot-nand_spl.lds
 # $(LDSCRIPT). The function make_u_boot_list is defined in helper.mk file.
 $(eval $(call make_u_boot_list, $(LSTSCRIPT), $(OBJS)))
 $(nandobj)u-boot-nand_spl.lds: $(LDSCRIPT) $(LSTSCRIPT)
-	$(CPP) $(CPPFLAGS) $(LDPPFLAGS) -I$(obj) -ansi -D__ASSEMBLY__ -P - <$< >$@
+	$(CPP) $(CPPFLAGS) $(LDPPFLAGS) -I$(nandobj)/board/$(BOARDDIR) \
+		-ansi -D__ASSEMBLY__ -P - <$< >$@
 
 # create symbolic links for common files
 
diff --git a/nand_spl/board/freescale/mx31pdk/Makefile b/nand_spl/board/freescale/mx31pdk/Makefile
index 43e72c4..f67ed09 100644
--- a/nand_spl/board/freescale/mx31pdk/Makefile
+++ b/nand_spl/board/freescale/mx31pdk/Makefile
@@ -42,7 +42,8 @@ $(nandobj)u-boot-spl:	$(OBJS) $(nandobj)u-boot.lds
 # $(LDSCRIPT). The function make_u_boot_list is defined in helper.mk file.
 $(eval $(call make_u_boot_list, $(LSTSCRIPT), $(OBJS)))
 $(nandobj)u-boot.lds: $(LDSCRIPT) $(LSTSCRIPT)
-	$(CPP) $(CPPFLAGS) $(LDPPFLAGS) -I$(obj) -ansi -D__ASSEMBLY__ -P - <$< >$@
+	$(CPP) $(CPPFLAGS) $(LDPPFLAGS) -I$(nandobj)/board/$(BOARDDIR) \
+		-ansi -D__ASSEMBLY__ -P - <$< >$@
 
 #########################################################################
 
diff --git a/nand_spl/board/freescale/p1010rdb/Makefile b/nand_spl/board/freescale/p1010rdb/Makefile
index ccff1c7..c3495ec 100644
--- a/nand_spl/board/freescale/p1010rdb/Makefile
+++ b/nand_spl/board/freescale/p1010rdb/Makefile
@@ -67,7 +67,8 @@ $(nandobj)u-boot-spl:	$(OBJS) $(nandobj)u-boot-nand_spl.lds
 # $(LDSCRIPT). The function make_u_boot_list is defined in helper.mk file.
 $(eval $(call make_u_boot_list, $(LSTSCRIPT), $(OBJS)))
 $(nandobj)u-boot-nand_spl.lds: $(LDSCRIPT) $(LSTSCRIPT)
-	$(CPP) $(CPPFLAGS) $(LDPPFLAGS) -I$(obj) -ansi -D__ASSEMBLY__ -P - <$< >$@
+	$(CPP) $(CPPFLAGS) $(LDPPFLAGS) -I$(nandobj)board/$(BOARDDIR) \
+		 -ansi -D__ASSEMBLY__ -P - <$< >$@
 
 # create symbolic links for common files
 
diff --git a/nand_spl/board/freescale/p1023rds/Makefile b/nand_spl/board/freescale/p1023rds/Makefile
index ffe29c8..9b2c0d7 100644
--- a/nand_spl/board/freescale/p1023rds/Makefile
+++ b/nand_spl/board/freescale/p1023rds/Makefile
@@ -62,7 +62,8 @@ $(nandobj)u-boot-spl:	$(OBJS) $(nandobj)u-boot-nand_spl.lds
 # $(LDSCRIPT). The function make_u_boot_list is defined in helper.mk file.
 $(eval $(call make_u_boot_list, $(LSTSCRIPT), $(OBJS)))
 $(nandobj)u-boot-nand_spl.lds: $(LDSCRIPT) $(LSTSCRIPT)
-	$(CPP) $(CPPFLAGS) $(LDPPFLAGS) -I$(obj) -ansi -D__ASSEMBLY__ -P - <$< >$@
+	$(CPP) $(CPPFLAGS) $(LDPPFLAGS) -I$(nandobj)/board/$(BOARDDIR) \
+		-ansi -D__ASSEMBLY__ -P - <$< >$@
 
 # create symbolic links for common files
 
diff --git a/nand_spl/board/freescale/p1_p2_rdb/Makefile b/nand_spl/board/freescale/p1_p2_rdb/Makefile
index c923557..9c77826 100644
--- a/nand_spl/board/freescale/p1_p2_rdb/Makefile
+++ b/nand_spl/board/freescale/p1_p2_rdb/Makefile
@@ -67,7 +67,8 @@ $(nandobj)u-boot-spl:	$(OBJS) $(nandobj)u-boot-nand_spl.lds
 # $(LDSCRIPT). The function make_u_boot_list is defined in helper.mk file.
 $(eval $(call make_u_boot_list, $(LSTSCRIPT), $(OBJS)))
 $(nandobj)u-boot-nand_spl.lds: $(LDSCRIPT) $(LSTSCRIPT)
-	$(CPP) $(CPPFLAGS) $(LDPPFLAGS) -I$(obj) -ansi -D__ASSEMBLY__ -P - <$< >$@
+	$(CPP) $(CPPFLAGS) $(LDPPFLAGS) -I$(nandobj)/board/$(BOARDDIR) \
+		-ansi -D__ASSEMBLY__ -P - <$< >$@
 
 # create symbolic links for common files
 
diff --git a/nand_spl/board/karo/tx25/Makefile b/nand_spl/board/karo/tx25/Makefile
index becf7fa..b27189d 100644
--- a/nand_spl/board/karo/tx25/Makefile
+++ b/nand_spl/board/karo/tx25/Makefile
@@ -63,7 +63,8 @@ $(nandobj)u-boot-spl:	$(OBJS) $(nandobj)u-boot.lds
 # $(LDSCRIPT). The function make_u_boot_list is defined in helper.mk file.
 $(eval $(call make_u_boot_list, $(LSTSCRIPT), $(OBJS)))
 $(nandobj)u-boot.lds: $(LDSCRIPT) $(LSTSCRIPT)
-	$(CPP) $(CPPFLAGS) $(LDPPFLAGS) -I$(obj) -ansi -D__ASSEMBLY__ -P - <$< >$@
+	$(CPP) $(CPPFLAGS) $(LDPPFLAGS) -I$(nandobj)/board/$(BOARDDIR) \
+		-ansi -D__ASSEMBLY__ -P - <$< >$@
 
 #########################################################################
 
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH] nand_spl: fix u-boot.lst breakage
  2012-11-13 22:30 [U-Boot] [PATCH] nand_spl: fix u-boot.lst breakage Scott Wood
@ 2012-11-13 23:17 ` Marek Vasut
  2012-11-14  6:49   ` Wolfgang Denk
  2012-11-14 10:18 ` Anatolij Gustschin
  1 sibling, 1 reply; 4+ messages in thread
From: Marek Vasut @ 2012-11-13 23:17 UTC (permalink / raw)
  To: u-boot

Dear Scott Wood,

> Commit 97b24d3d51a92cb8c0c1e1a74abf22fe1a1807a3 "common: Add symbol
> handling for generic lists into Makefile" introduced build errors in many
> nand_spl targets, complaining of a missing u-boot.lst.  When not doing an
> out-of-tree build, $(obj) expands to nothing, so GCC ended up being given
> -I with no argument (or rather, -ansi was the argument).

Here comes Wolfgangs' "in-tree builds have no benefit" ;)

> The failure
> didn't show up during a -j1 build because it was picking up the non-SPL
> version of u-boot.lst.

ICK ... thanks for fixing it.

It seems my warm stop under the rock won't get cold any soon due to my recent 
changes to uboot source ... crawl crawl crawl ...

> Signed-off-by: Scott Wood <scottwood@freescale.com>
> ---
> I didn't fix p1_p2_rdb_pc because that will just conflict with the
> patchset that migrates that target away from nand_spl.
> 
>  nand_spl/board/freescale/mpc8536ds/Makefile  |    3 ++-
>  nand_spl/board/freescale/mpc8569mds/Makefile |    3 ++-
>  nand_spl/board/freescale/mpc8572ds/Makefile  |    3 ++-
>  nand_spl/board/freescale/mx31pdk/Makefile    |    3 ++-
>  nand_spl/board/freescale/p1010rdb/Makefile   |    3 ++-
>  nand_spl/board/freescale/p1023rds/Makefile   |    3 ++-
>  nand_spl/board/freescale/p1_p2_rdb/Makefile  |    3 ++-
>  nand_spl/board/karo/tx25/Makefile            |    3 ++-
>  8 files changed, 16 insertions(+), 8 deletions(-)
> 
> diff --git a/nand_spl/board/freescale/mpc8536ds/Makefile
> b/nand_spl/board/freescale/mpc8536ds/Makefile index c923557..9c77826
> 100644
> --- a/nand_spl/board/freescale/mpc8536ds/Makefile
> +++ b/nand_spl/board/freescale/mpc8536ds/Makefile
> @@ -67,7 +67,8 @@ $(nandobj)u-boot-spl:	$(OBJS)
> $(nandobj)u-boot-nand_spl.lds # $(LDSCRIPT). The function make_u_boot_list
> is defined in helper.mk file. $(eval $(call make_u_boot_list,
> $(LSTSCRIPT), $(OBJS)))
>  $(nandobj)u-boot-nand_spl.lds: $(LDSCRIPT) $(LSTSCRIPT)
> -	$(CPP) $(CPPFLAGS) $(LDPPFLAGS) -I$(obj) -ansi -D__ASSEMBLY__ -P - <$<
> >$@ +	$(CPP) $(CPPFLAGS) $(LDPPFLAGS) -I$(nandobj)/board/$(BOARDDIR) \
> +		-ansi -D__ASSEMBLY__ -P - <$< >$@
> 
>  # create symbolic links for common files
> 
> diff --git a/nand_spl/board/freescale/mpc8569mds/Makefile
> b/nand_spl/board/freescale/mpc8569mds/Makefile index c923557..9c77826
> 100644
> --- a/nand_spl/board/freescale/mpc8569mds/Makefile
> +++ b/nand_spl/board/freescale/mpc8569mds/Makefile
> @@ -67,7 +67,8 @@ $(nandobj)u-boot-spl:	$(OBJS)
> $(nandobj)u-boot-nand_spl.lds # $(LDSCRIPT). The function make_u_boot_list
> is defined in helper.mk file. $(eval $(call make_u_boot_list,
> $(LSTSCRIPT), $(OBJS)))
>  $(nandobj)u-boot-nand_spl.lds: $(LDSCRIPT) $(LSTSCRIPT)
> -	$(CPP) $(CPPFLAGS) $(LDPPFLAGS) -I$(obj) -ansi -D__ASSEMBLY__ -P - <$<
> >$@ +	$(CPP) $(CPPFLAGS) $(LDPPFLAGS) -I$(nandobj)/board/$(BOARDDIR) \
> +		-ansi -D__ASSEMBLY__ -P - <$< >$@
> 
>  # create symbolic links for common files
> 
> diff --git a/nand_spl/board/freescale/mpc8572ds/Makefile
> b/nand_spl/board/freescale/mpc8572ds/Makefile index c923557..9c77826
> 100644
> --- a/nand_spl/board/freescale/mpc8572ds/Makefile
> +++ b/nand_spl/board/freescale/mpc8572ds/Makefile
> @@ -67,7 +67,8 @@ $(nandobj)u-boot-spl:	$(OBJS)
> $(nandobj)u-boot-nand_spl.lds # $(LDSCRIPT). The function make_u_boot_list
> is defined in helper.mk file. $(eval $(call make_u_boot_list,
> $(LSTSCRIPT), $(OBJS)))
>  $(nandobj)u-boot-nand_spl.lds: $(LDSCRIPT) $(LSTSCRIPT)
> -	$(CPP) $(CPPFLAGS) $(LDPPFLAGS) -I$(obj) -ansi -D__ASSEMBLY__ -P - <$<
> >$@ +	$(CPP) $(CPPFLAGS) $(LDPPFLAGS) -I$(nandobj)/board/$(BOARDDIR) \
> +		-ansi -D__ASSEMBLY__ -P - <$< >$@
> 
>  # create symbolic links for common files
> 
> diff --git a/nand_spl/board/freescale/mx31pdk/Makefile
> b/nand_spl/board/freescale/mx31pdk/Makefile index 43e72c4..f67ed09 100644
> --- a/nand_spl/board/freescale/mx31pdk/Makefile
> +++ b/nand_spl/board/freescale/mx31pdk/Makefile
> @@ -42,7 +42,8 @@ $(nandobj)u-boot-spl:	$(OBJS) $(nandobj)u-boot.lds
>  # $(LDSCRIPT). The function make_u_boot_list is defined in helper.mk file.
>  $(eval $(call make_u_boot_list, $(LSTSCRIPT), $(OBJS)))
>  $(nandobj)u-boot.lds: $(LDSCRIPT) $(LSTSCRIPT)
> -	$(CPP) $(CPPFLAGS) $(LDPPFLAGS) -I$(obj) -ansi -D__ASSEMBLY__ -P - <$<
> >$@ +	$(CPP) $(CPPFLAGS) $(LDPPFLAGS) -I$(nandobj)/board/$(BOARDDIR) \
> +		-ansi -D__ASSEMBLY__ -P - <$< >$@
> 
>  #########################################################################
> 
> diff --git a/nand_spl/board/freescale/p1010rdb/Makefile
> b/nand_spl/board/freescale/p1010rdb/Makefile index ccff1c7..c3495ec 100644
> --- a/nand_spl/board/freescale/p1010rdb/Makefile
> +++ b/nand_spl/board/freescale/p1010rdb/Makefile
> @@ -67,7 +67,8 @@ $(nandobj)u-boot-spl:	$(OBJS)
> $(nandobj)u-boot-nand_spl.lds # $(LDSCRIPT). The function make_u_boot_list
> is defined in helper.mk file. $(eval $(call make_u_boot_list,
> $(LSTSCRIPT), $(OBJS)))
>  $(nandobj)u-boot-nand_spl.lds: $(LDSCRIPT) $(LSTSCRIPT)
> -	$(CPP) $(CPPFLAGS) $(LDPPFLAGS) -I$(obj) -ansi -D__ASSEMBLY__ -P - <$<
> >$@ +	$(CPP) $(CPPFLAGS) $(LDPPFLAGS) -I$(nandobj)board/$(BOARDDIR) \
> +		 -ansi -D__ASSEMBLY__ -P - <$< >$@
> 
>  # create symbolic links for common files
> 
> diff --git a/nand_spl/board/freescale/p1023rds/Makefile
> b/nand_spl/board/freescale/p1023rds/Makefile index ffe29c8..9b2c0d7 100644
> --- a/nand_spl/board/freescale/p1023rds/Makefile
> +++ b/nand_spl/board/freescale/p1023rds/Makefile
> @@ -62,7 +62,8 @@ $(nandobj)u-boot-spl:	$(OBJS)
> $(nandobj)u-boot-nand_spl.lds # $(LDSCRIPT). The function make_u_boot_list
> is defined in helper.mk file. $(eval $(call make_u_boot_list,
> $(LSTSCRIPT), $(OBJS)))
>  $(nandobj)u-boot-nand_spl.lds: $(LDSCRIPT) $(LSTSCRIPT)
> -	$(CPP) $(CPPFLAGS) $(LDPPFLAGS) -I$(obj) -ansi -D__ASSEMBLY__ -P - <$<
> >$@ +	$(CPP) $(CPPFLAGS) $(LDPPFLAGS) -I$(nandobj)/board/$(BOARDDIR) \
> +		-ansi -D__ASSEMBLY__ -P - <$< >$@
> 
>  # create symbolic links for common files
> 
> diff --git a/nand_spl/board/freescale/p1_p2_rdb/Makefile
> b/nand_spl/board/freescale/p1_p2_rdb/Makefile index c923557..9c77826
> 100644
> --- a/nand_spl/board/freescale/p1_p2_rdb/Makefile
> +++ b/nand_spl/board/freescale/p1_p2_rdb/Makefile
> @@ -67,7 +67,8 @@ $(nandobj)u-boot-spl:	$(OBJS)
> $(nandobj)u-boot-nand_spl.lds # $(LDSCRIPT). The function make_u_boot_list
> is defined in helper.mk file. $(eval $(call make_u_boot_list,
> $(LSTSCRIPT), $(OBJS)))
>  $(nandobj)u-boot-nand_spl.lds: $(LDSCRIPT) $(LSTSCRIPT)
> -	$(CPP) $(CPPFLAGS) $(LDPPFLAGS) -I$(obj) -ansi -D__ASSEMBLY__ -P - <$<
> >$@ +	$(CPP) $(CPPFLAGS) $(LDPPFLAGS) -I$(nandobj)/board/$(BOARDDIR) \
> +		-ansi -D__ASSEMBLY__ -P - <$< >$@
> 
>  # create symbolic links for common files
> 
> diff --git a/nand_spl/board/karo/tx25/Makefile
> b/nand_spl/board/karo/tx25/Makefile index becf7fa..b27189d 100644
> --- a/nand_spl/board/karo/tx25/Makefile
> +++ b/nand_spl/board/karo/tx25/Makefile
> @@ -63,7 +63,8 @@ $(nandobj)u-boot-spl:	$(OBJS) $(nandobj)u-boot.lds
>  # $(LDSCRIPT). The function make_u_boot_list is defined in helper.mk file.
>  $(eval $(call make_u_boot_list, $(LSTSCRIPT), $(OBJS)))
>  $(nandobj)u-boot.lds: $(LDSCRIPT) $(LSTSCRIPT)
> -	$(CPP) $(CPPFLAGS) $(LDPPFLAGS) -I$(obj) -ansi -D__ASSEMBLY__ -P - <$<
> >$@ +	$(CPP) $(CPPFLAGS) $(LDPPFLAGS) -I$(nandobj)/board/$(BOARDDIR) \
> +		-ansi -D__ASSEMBLY__ -P - <$< >$@
> 
>  #########################################################################

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH] nand_spl: fix u-boot.lst breakage
  2012-11-13 23:17 ` Marek Vasut
@ 2012-11-14  6:49   ` Wolfgang Denk
  0 siblings, 0 replies; 4+ messages in thread
From: Wolfgang Denk @ 2012-11-14  6:49 UTC (permalink / raw)
  To: u-boot

Dear Marek Vasut,

In message <201211140017.02013.marex@denx.de> you wrote:
> 
> > Commit 97b24d3d51a92cb8c0c1e1a74abf22fe1a1807a3 "common: Add symbol
> > handling for generic lists into Makefile" introduced build errors in many
> > nand_spl targets, complaining of a missing u-boot.lst.  When not doing an
> > out-of-tree build, $(obj) expands to nothing, so GCC ended up being given
> > -I with no argument (or rather, -ansi was the argument).
> 
> Here comes Wolfgangs' "in-tree builds have no benefit" ;)

Please do not misquote me.  I never said anything like that.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"If the code and  the  comments  disagree,  then  both  are  probably
wrong."                                                - Norm Schryer

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH] nand_spl: fix u-boot.lst breakage
  2012-11-13 22:30 [U-Boot] [PATCH] nand_spl: fix u-boot.lst breakage Scott Wood
  2012-11-13 23:17 ` Marek Vasut
@ 2012-11-14 10:18 ` Anatolij Gustschin
  1 sibling, 0 replies; 4+ messages in thread
From: Anatolij Gustschin @ 2012-11-14 10:18 UTC (permalink / raw)
  To: u-boot

Hi,

On Tue, 13 Nov 2012 16:30:39 -0600
Scott Wood <scottwood@freescale.com> wrote:

> Commit 97b24d3d51a92cb8c0c1e1a74abf22fe1a1807a3 "common: Add symbol
> handling for generic lists into Makefile" introduced build errors in many
> nand_spl targets, complaining of a missing u-boot.lst.  When not doing an
> out-of-tree build, $(obj) expands to nothing, so GCC ended up being given
> -I with no argument (or rather, -ansi was the argument).  The failure
> didn't show up during a -j1 build because it was picking up the non-SPL
> version of u-boot.lst.
> 
> Signed-off-by: Scott Wood <scottwood@freescale.com>
> ---
> I didn't fix p1_p2_rdb_pc because that will just conflict with the
> patchset that migrates that target away from nand_spl.
> 
>  nand_spl/board/freescale/mpc8536ds/Makefile  |    3 ++-
>  nand_spl/board/freescale/mpc8569mds/Makefile |    3 ++-
>  nand_spl/board/freescale/mpc8572ds/Makefile  |    3 ++-
>  nand_spl/board/freescale/mx31pdk/Makefile    |    3 ++-
>  nand_spl/board/freescale/p1010rdb/Makefile   |    3 ++-
>  nand_spl/board/freescale/p1023rds/Makefile   |    3 ++-
>  nand_spl/board/freescale/p1_p2_rdb/Makefile  |    3 ++-
>  nand_spl/board/karo/tx25/Makefile            |    3 ++-
>  8 files changed, 16 insertions(+), 8 deletions(-)

Appied to staging/agust at denx.de, thanks!

Anatolij

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2012-11-14 10:18 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-13 22:30 [U-Boot] [PATCH] nand_spl: fix u-boot.lst breakage Scott Wood
2012-11-13 23:17 ` Marek Vasut
2012-11-14  6:49   ` Wolfgang Denk
2012-11-14 10:18 ` Anatolij Gustschin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox