public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] what does it mean when "SOBJS" refers to a C source file?
Date: Thu, 15 Nov 2012 08:09:08 +0100	[thread overview]
Message-ID: <20121115080908.38b76c6b@lilith> (raw)
In-Reply-To: <alpine.DEB.2.02.1211141505250.3572@oneiric>

Hi Robert,

On Wed, 14 Nov 2012 15:06:48 -0500 (EST), "Robert P. J. Day"
<rpjday@crashcourse.ca> wrote:

> On Wed, 14 Nov 2012, Albert ARIBAUD wrote:
> 
> > Hi Robert,
> >
> > On Wed, 14 Nov 2012 11:32:11 -0500 (EST), "Robert P. J. Day"
> > <rpjday@crashcourse.ca> wrote:
> >
> > >
> > >   perusing the Makefiles, pretty straightforward but, on occasion, i
> > > run into something like this (from
> > > arch/arm/cpu/armv7/omap-common/Makefile):
> > >
> > > ... snip ...
> > > SOBJS   := reset.o
> > >
> > > COBJS   := timer.o
> > > COBJS   += utils.o
> > > ... snip ...
> > >
> > >   the thing is, all of the above are .c files, including reset.c.  is
> > > there something deliberate about using SOBJS to refer to an object
> > > file whose source file isn't actually assembler?  just curious.
> > >
> > > rday
> >
> > It means commit d417d1db5f9092d125ddea882ced77eaa5f3d236 was not
> > reviewed thoroughly enough. :)
> 
>   i can submit a patch for that unless someone is all over that
> already.  i assume the fix would simply involve assigning reset.o to
> COBJS (rather than SOBS) in the relevant Makefiles, yes?

Yes -- and checking that the resulting U-Boot still builds and
works. :)

> rday

Amicalement,
-- 
Albert.

      reply	other threads:[~2012-11-15  7:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-14 16:32 [U-Boot] what does it mean when "SOBJS" refers to a C source file? Robert P. J. Day
2012-11-14 18:44 ` Albert ARIBAUD
2012-11-14 20:06   ` Robert P. J. Day
2012-11-15  7:09     ` Albert ARIBAUD [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121115080908.38b76c6b@lilith \
    --to=albert.u.boot@aribaud.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox