[U-Boot] what does it mean when "SOBJS" refers to a C source file?

[U-Boot] what does it mean when "SOBJS" refers to a C source file?

[Robert P. J. Day]

  perusing the Makefiles, pretty straightforward but, on occasion, i
run into something like this (from
arch/arm/cpu/armv7/omap-common/Makefile):

... snip ...
SOBJS   := reset.o

COBJS   := timer.o
COBJS   += utils.o
... snip ...

  the thing is, all of the above are .c files, including reset.c.  is
there something deliberate about using SOBJS to refer to an object
file whose source file isn't actually assembler?  just curious.

rday

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================

[U-Boot] what does it mean when "SOBJS" refers to a C source file?

[Albert ARIBAUD]

Hi Robert,

On Wed, 14 Nov 2012 11:32:11 -0500 (EST), "Robert P. J. Day"
<rpjday@crashcourse.ca> wrote:

> 
>   perusing the Makefiles, pretty straightforward but, on occasion, i
> run into something like this (from
> arch/arm/cpu/armv7/omap-common/Makefile):
> 
> ... snip ...
> SOBJS   := reset.o
> 
> COBJS   := timer.o
> COBJS   += utils.o
> ... snip ...
> 
>   the thing is, all of the above are .c files, including reset.c.  is
> there something deliberate about using SOBJS to refer to an object
> file whose source file isn't actually assembler?  just curious.
> 
> rday

It means commit d417d1db5f9092d125ddea882ced77eaa5f3d236 was not
reviewed thoroughly enough. :)

Amicalement,
-- 
Albert.

[U-Boot] what does it mean when "SOBJS" refers to a C source file?

[Robert P. J. Day]

On Wed, 14 Nov 2012, Albert ARIBAUD wrote:

> Hi Robert,
>
> On Wed, 14 Nov 2012 11:32:11 -0500 (EST), "Robert P. J. Day"
> <rpjday@crashcourse.ca> wrote:
>
> >
> >   perusing the Makefiles, pretty straightforward but, on occasion, i
> > run into something like this (from
> > arch/arm/cpu/armv7/omap-common/Makefile):
> >
> > ... snip ...
> > SOBJS   := reset.o
> >
> > COBJS   := timer.o
> > COBJS   += utils.o
> > ... snip ...
> >
> >   the thing is, all of the above are .c files, including reset.c.  is
> > there something deliberate about using SOBJS to refer to an object
> > file whose source file isn't actually assembler?  just curious.
> >
> > rday
>
> It means commit d417d1db5f9092d125ddea882ced77eaa5f3d236 was not
> reviewed thoroughly enough. :)

  i can submit a patch for that unless someone is all over that
already.  i assume the fix would simply involve assigning reset.o to
COBJS (rather than SOBS) in the relevant Makefiles, yes?

rday

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================

[U-Boot] what does it mean when "SOBJS" refers to a C source file?

[Albert ARIBAUD]

Hi Robert,

On Wed, 14 Nov 2012 15:06:48 -0500 (EST), "Robert P. J. Day"
<rpjday@crashcourse.ca> wrote:

> On Wed, 14 Nov 2012, Albert ARIBAUD wrote:
> 
> > Hi Robert,
> >
> > On Wed, 14 Nov 2012 11:32:11 -0500 (EST), "Robert P. J. Day"
> > <rpjday@crashcourse.ca> wrote:
> >
> > >
> > >   perusing the Makefiles, pretty straightforward but, on occasion, i
> > > run into something like this (from
> > > arch/arm/cpu/armv7/omap-common/Makefile):
> > >
> > > ... snip ...
> > > SOBJS   := reset.o
> > >
> > > COBJS   := timer.o
> > > COBJS   += utils.o
> > > ... snip ...
> > >
> > >   the thing is, all of the above are .c files, including reset.c.  is
> > > there something deliberate about using SOBJS to refer to an object
> > > file whose source file isn't actually assembler?  just curious.
> > >
> > > rday
> >
> > It means commit d417d1db5f9092d125ddea882ced77eaa5f3d236 was not
> > reviewed thoroughly enough. :)
> 
>   i can submit a patch for that unless someone is all over that
> already.  i assume the fix would simply involve assigning reset.o to
> COBJS (rather than SOBS) in the relevant Makefiles, yes?

Yes -- and checking that the resulting U-Boot still builds and
works. :)

> rday

Amicalement,
-- 
Albert.