[U-Boot] usb: ehci: Take advantage of the new multi-controller feature for MXC

Marek Vasut
2012-11-06T22:35:59Z

Dear Lucas Stach,

[...]

> > > > > What do you think?
> > > >
> > > > What about passing port private / platform data instead of ID ?
> > >
> > > The ID is already passed to ehci_hcd_init(), so we have to live with it
> > > if we don't want to change the newly introduced multi-controller
> > > infrastructure.
> >
> > Let's change it .... remove the ID and pass some generic pdata.
>
> I don't like the idea of passing around data at this level. It's
> breaking the abstraction, as we have to pass low-level usb information
> around in the higher USB stack levels.

Good, what do you suggest we do when we apply driver model onto this stuff?

> The USB driver code should be able to do the virt-to-phys controller
> mapping on it's own. In the Tegra world

Tegra is completely unimportant part of the usb ecosystem.

> we use the information we get
> from device tree to do so, but I don't see a reason why your USB host
> driver code wouldn't be able to just require an array with configuration
> data from the board file.

I don't see how you transfer DT information into controller # ...

> There is really no need to pass this information through all the USB
> stack interfaces.

Please explain.

> Regards,
> Lucas