From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] ARM: OMAP5: redefine arm_setup_identity_mapping
Date: Mon, 19 Nov 2012 15:49:53 -0500 [thread overview]
Message-ID: <20121119204953.GG9467@oliver-linux> (raw)
In-Reply-To: <1353337174-9858-3-git-send-email-v-stehle@ti.com>
On Mon, Nov 19, 2012 at 03:59:34PM +0100, Vincent Stehl? wrote:
> We introduce an OMAP5 specific version of arm_setup_identity_mapping(), which
> makes the first page of the identity mapping invalid.
>
> We want to unmap the region near address zero on HS OMAP devices, to avoid
> speculative accesses. Accessing this region causes security violations, which
> we want to avoid.
>
> Signed-off-by: Vincent Stehl? <v-stehle@ti.com>
[snip]
> + /* Perform default mapping, which sets up an identity-mapping for all
> + * 4GB, rw for everyone */
/*
* Multi-line comments must all be like this.
*/
Aside from that (and the comment to 1/2) I think we're good here,
including the naming of the function. Thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20121119/c80f8eba/attachment.pgp>
next prev parent reply other threads:[~2012-11-19 20:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-16 13:36 [U-Boot] [RFC, PATCH] omap: Invalidate first page to avoid speculation Vincent Stehlé
2012-11-16 20:52 ` Albert ARIBAUD
2012-11-19 14:59 ` [U-Boot] [RFC, PATCH v2] " Vincent Stehlé
2012-11-19 14:59 ` [U-Boot] [PATCH 1/2] ARM: cache: introduce weak arm_setup_identity_mapping Vincent Stehlé
2012-11-19 20:48 ` Tom Rini
2012-11-19 14:59 ` [U-Boot] [PATCH 2/2] ARM: OMAP5: redefine arm_setup_identity_mapping Vincent Stehlé
2012-11-19 20:49 ` Tom Rini [this message]
2012-11-20 11:01 ` [U-Boot] [RFC, PATCH v3] omap: Invalidate first page to avoid speculation Vincent Stehlé
2012-11-20 11:01 ` [U-Boot] [PATCH 1/2] ARM: cache: introduce weak arm_setup_identity_mapping Vincent Stehlé
2012-11-20 11:01 ` [U-Boot] [PATCH 2/2] ARM: OMAP5: redefine arm_setup_identity_mapping Vincent Stehlé
2012-12-11 15:35 ` [U-Boot] [PATCH v2] " Vincent Stehlé
2012-12-11 15:43 ` Tom Rini
2012-12-11 16:06 ` Vincent Stehlé
2012-12-11 16:06 ` [U-Boot] [PATCH v3 1/2] ARM: cache: introduce weak arm_setup_identity_mapping Vincent Stehlé
2012-12-11 16:06 ` [U-Boot] [PATCH v3 2/2] ARM: OMAP5: redefine arm_setup_identity_mapping Vincent Stehlé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121119204953.GG9467@oliver-linux \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox