From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Mon, 19 Nov 2012 15:49:53 -0500 Subject: [U-Boot] [PATCH 2/2] ARM: OMAP5: redefine arm_setup_identity_mapping In-Reply-To: <1353337174-9858-3-git-send-email-v-stehle@ti.com> References: <20121116215251.471c148a@lilith> <1353337174-9858-1-git-send-email-v-stehle@ti.com> <1353337174-9858-3-git-send-email-v-stehle@ti.com> Message-ID: <20121119204953.GG9467@oliver-linux> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, Nov 19, 2012 at 03:59:34PM +0100, Vincent Stehl? wrote: > We introduce an OMAP5 specific version of arm_setup_identity_mapping(), which > makes the first page of the identity mapping invalid. > > We want to unmap the region near address zero on HS OMAP devices, to avoid > speculative accesses. Accessing this region causes security violations, which > we want to avoid. > > Signed-off-by: Vincent Stehl? [snip] > + /* Perform default mapping, which sets up an identity-mapping for all > + * 4GB, rw for everyone */ /* * Multi-line comments must all be like this. */ Aside from that (and the comment to 1/2) I think we're good here, including the naming of the function. Thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: