From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 17/17] tpm: Add TPM stress test
Date: Tue, 20 Nov 2012 00:50:46 +0100 [thread overview]
Message-ID: <201211200050.46323.marex@denx.de> (raw)
In-Reply-To: <CAPnjgZ2K25mC6-AcTchgn_dU3tvEc-jDtUENi6UNmkcxW4d=4A@mail.gmail.com>
Dear Simon Glass,
> Hi Wolfgang,
>
> On Sat, Nov 3, 2012 at 8:29 AM, Wolfgang Denk <wd@denx.de> wrote:
> > Dear Simon Glass,
> >
> > In message <1351902453-27956-18-git-send-email-sjg@chromium.org> you wrote:
> >> From: Luigi Semenzato <semenzato@chromium.org>
> >>
> >> Add a simple command to stress-test a TPM (Trusted Platform Module).
> >>
> >> Signed-off-by: Luigi Semenzato <semenzato@chromium.org>
> >>
> >> Commit-Ready: Stefan Reinauer <reinauer@google.com>
> >> Signed-off-by: Simon Glass <sjg@chromium.org>
> >> ---
> >>
> >> common/cmd_tpm.c | 93
> >> ++++++++++++++++++++++++++++++++++++++++++++++++++--- 1 files changed,
> >> 87 insertions(+), 6 deletions(-)
> >
> > See previous comments about TPM code. Please let's dump all this
> > unused stuff.
>
> As mentioned, patches are pending to enable this for two boards (ARM and
> x86).
Hm, does this TPM argument still go on?
Actually, my position is I'd be all for dumping it right away (I even posted a
patch some time ago), if it wasn't for SJG posting patches adding another TPM
chip. Moreover, now I see there are patches for cmd_tpm.c . So I see a lot of
effort invested into doing the TPM right.
What is the actual problem with keeping this code in our codebase and patching
it then? It's all used now, problem solved, or am I missing something?
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-11-19 23:50 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-03 0:27 [U-Boot] [PATCH 0/17] Various patches in common/ Simon Glass
2012-11-03 0:27 ` [U-Boot] [PATCH 01/17] arm: Add new bootstage step for the main loop Simon Glass
2012-11-03 15:12 ` Wolfgang Denk
2012-11-07 0:54 ` Simon Glass
2012-11-03 0:27 ` [U-Boot] [PATCH 02/17] Add gettime command Simon Glass
2012-11-03 8:22 ` Luka Perkov
2012-11-15 22:23 ` Simon Glass
2012-11-03 15:24 ` Wolfgang Denk
2012-11-15 22:15 ` Simon Glass
2012-11-03 0:27 ` [U-Boot] [PATCH 03/17] Add a command to read raw blocks from a partition Simon Glass
2012-11-03 0:27 ` [U-Boot] [PATCH 04/17] Fix use of conditional LMB Simon Glass
2012-11-03 0:27 ` [U-Boot] [PATCH 05/17] stdio: remove useless strncpy Simon Glass
2012-11-03 15:31 ` Wolfgang Denk
2012-11-15 22:25 ` Simon Glass
2012-11-03 0:27 ` [U-Boot] [PATCH 06/17] env: Add the ability to merge the saved env with the default Simon Glass
2012-11-03 15:28 ` Wolfgang Denk
2012-11-07 0:53 ` Simon Glass
2012-11-03 0:27 ` [U-Boot] [PATCH 07/17] Add coreboot version to u-boot's version command Simon Glass
2012-11-03 0:27 ` [U-Boot] [PATCH 08/17] Update time command to avoid using get_timer_masked() Simon Glass
2012-11-03 0:27 ` [U-Boot] [PATCH 09/17] Add sha256 command for hashing Simon Glass
2012-11-03 15:23 ` Wolfgang Denk
2012-11-22 14:48 ` Simon Glass
2012-11-03 0:27 ` [U-Boot] [PATCH 10/17] edid: Library of EDID decode and print Simon Glass
2012-11-03 0:27 ` [U-Boot] [PATCH 11/17] edid: Add I2C command for printing the EDID Simon Glass
2012-11-03 0:27 ` [U-Boot] [PATCH 12/17] fdt: edid: Enable fdt_add_edid() function when CONFIG_LCD defined Simon Glass
2012-11-03 0:27 ` [U-Boot] [PATCH 13/17] mmc: Fix incorrect handling of 'read' & 'write' commands Simon Glass
2012-11-03 0:27 ` [U-Boot] [PATCH 14/17] console: Call overwrite_console before searching for console devices Simon Glass
2012-11-03 15:32 ` Wolfgang Denk
2012-11-07 21:28 ` Simon Glass
2012-11-08 10:33 ` Wolfgang Denk
2012-11-03 0:27 ` [U-Boot] [PATCH 15/17] Add console command to access io space registers Simon Glass
2012-11-03 15:26 ` Wolfgang Denk
2012-11-15 23:28 ` Vadim Bendebury
2012-11-03 0:27 ` [U-Boot] [PATCH 16/17] console: Enable function to display console info Simon Glass
2012-11-03 15:15 ` Wolfgang Denk
2012-11-15 23:24 ` Simon Glass
2012-11-03 0:27 ` [U-Boot] [PATCH 17/17] tpm: Add TPM stress test Simon Glass
2012-11-03 15:29 ` Wolfgang Denk
2012-11-03 20:40 ` Simon Glass
2012-11-19 23:50 ` Marek Vasut [this message]
2012-11-20 1:11 ` Simon Glass
2012-11-20 2:16 ` Marek Vasut
2012-11-20 7:04 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201211200050.46323.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox