From: Lee Jones <lee.jones@linaro.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 5/8] arm: Add boottime support for the ARM architecture
Date: Wed, 21 Nov 2012 10:13:10 +0000 [thread overview]
Message-ID: <20121121101310.GL28265@gmail.com> (raw)
In-Reply-To: <20121121093018.B3D082003CF@gemini.denx.de>
> > > > This patch adds support for passing boot time information to
> > > > the Linus kernel using ATAGS when booting on ARM based devices.
> > >
> > > I implicitly mentioned this before, here it comes clear again:
> >
> > Ah, this has been tried before? Sorry, I didn't know that.
>
> I expolained it in my reply to your cover letter, i.e. in the message
> immediately preceeding the one you replied to here.
So you're telling me off for sending a patch which doesn't agree with
something you've said, despite you saying it _after_ I sent the patch?
Sounds sensible. :)
> > > I dislike the idea of adding such infrastructure in an archittecture
> > > dependent way, knowing from day one that we cannot use this as is for
> > > other architectures, and that the mechanism being used is even going
> > > to go away for this architecutre, too.
> > >
> > > Please come up with a solution that works for all architectures
> > > instead.
> >
> > So I guess Device Tree it is then.
>
> No. The device tree is for passing hardware information to U-Boot and
> the kernel. It is NOT intended for carrying things like debug or
> timing logs. It is not a good idea to misuse such services for things
> they were not made for nor where they fit.
Okay, got it.
> Please use a standard facility, and one designed for such purposes
> like the Linux log buffer for this purpose. As explained, this has
> the added benefit that you don't need to change any Linux code. And
> you can build on the (also existing) show_boot_progress() support in
> U-Boot, so the extesions should actually be really small and pretty
> clear.
When you say log buffer, do you mean __log_buf? Doesn't this contain
logs used for dmesg; thus won't all this crud end up in a user's
dmesg kernel log? Unless there is another log which is used only
for the kernel.
Also, wouldn't I then have to write a text parser to process this
information? Sounds horrendous. Hopefully, I have missed something
and it's actually easier than what I've mentioned.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2012-11-21 10:13 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-20 14:33 [U-Boot] [PATCH 0/8] Adding boottime support Lee Jones
2012-11-20 14:33 ` [U-Boot] [PATCH 1/8] u8500: Correct unnecessary mathematical roll-over Lee Jones
2012-11-20 18:14 ` Wolfgang Denk
2012-11-21 10:02 ` Lee Jones
2012-11-21 13:51 ` Wolfgang Denk
2012-11-21 14:54 ` Lee Jones
2012-11-20 14:33 ` [U-Boot] [PATCH 2/8] u8500: Add utimer support Lee Jones
2012-11-20 14:33 ` [U-Boot] [PATCH 3/8] boottime: Add core boottime measurement support Lee Jones
2012-11-20 18:20 ` Wolfgang Denk
2012-11-21 9:50 ` Lee Jones
2012-11-21 13:44 ` Wolfgang Denk
2012-11-21 15:03 ` Lee Jones
2012-11-21 16:14 ` Wolfgang Denk
2012-11-21 17:26 ` Lee Jones
2012-11-21 19:04 ` Wolfgang Denk
2012-11-26 6:08 ` Simon Glass
2012-11-26 9:00 ` Lee Jones
2012-11-26 19:57 ` Simon Glass
2012-11-27 8:55 ` Lee Jones
2012-11-27 13:46 ` Wolfgang Denk
2012-11-27 14:28 ` Lee Jones
2012-11-20 14:33 ` [U-Boot] [PATCH 4/8] boottime: Apply some key boottime tags into common code Lee Jones
2012-11-20 18:22 ` Wolfgang Denk
2012-11-21 9:36 ` Lee Jones
2012-11-21 13:40 ` Wolfgang Denk
2012-11-21 15:07 ` Lee Jones
2012-11-20 14:33 ` [U-Boot] [PATCH 5/8] arm: Add boottime support for the ARM architecture Lee Jones
2012-11-20 15:11 ` Otavio Salvador
2012-11-20 15:52 ` Lee Jones
2012-11-20 18:24 ` Wolfgang Denk
2012-11-21 9:17 ` Lee Jones
2012-11-21 9:30 ` Wolfgang Denk
2012-11-21 10:13 ` Lee Jones [this message]
2012-11-21 13:58 ` Wolfgang Denk
2012-11-21 14:39 ` Lee Jones
2012-11-21 16:05 ` Wolfgang Denk
2012-11-21 17:48 ` Lee Jones
2012-11-21 19:18 ` Wolfgang Denk
2012-11-22 10:14 ` Lee Jones
2012-11-22 13:04 ` Wolfgang Denk
2012-11-22 16:08 ` Lee Jones
2012-11-22 17:40 ` Wolfgang Denk
2012-11-23 10:08 ` Lee Jones
2012-11-20 14:33 ` [U-Boot] [PATCH 6/8] arm: Add some boottime tags into prime booting locations Lee Jones
2012-11-20 14:33 ` [U-Boot] [PATCH 7/8] href: Enable boottime functionality Lee Jones
2012-11-20 14:33 ` [U-Boot] [PATCH 8/8] snowball: " Lee Jones
2012-11-20 18:08 ` [U-Boot] [PATCH 0/8] Adding boottime support Wolfgang Denk
2012-11-21 10:03 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121121101310.GL28265@gmail.com \
--to=lee.jones@linaro.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox