From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Wed, 21 Nov 2012 14:40:12 +0100 Subject: [U-Boot] [PATCH 4/8] boottime: Apply some key boottime tags into common code In-Reply-To: <20121121093647.GH28265@gmail.com> References: <1353422034-28107-1-git-send-email-lee.jones@linaro.org> <1353422034-28107-5-git-send-email-lee.jones@linaro.org> <20121120182229.0156A20009C@gemini.denx.de> <20121121093647.GH28265@gmail.com> Message-ID: <20121121134012.204AB2003CF@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Lee Jones, In message <20121121093647.GH28265@gmail.com> you wrote: > > > show_boot_progress() code? Did you consider using this instead? If > > so, why did you not use it? > > No, I didn't know it existed. Basically I've taken responsibility to > upstream someone else's driver. It's more of a kernel thing, but it This shouldbe considered a design fault. Why do you need an extra driver when standard mechanisms exist that provide exactly the needed funtionality? > requires boottime information from u-boot too, as the intention is > to cover full system booting, rather than the kernel-only tracing > mechanisms which already exist. But we can share a log buffer with Linux, both hence and back, so why do you not simply use this feature? > I've just taken a look at show_boot_process() though. It doesn't > appear to be suitable for what we require. Each tag needs to be > individually identifiable, and I'm not sure how you would achieve > this if we were to call back into a single function which would do > the tagging. Each call takes an argument which is exactly used for such identification purposes. And you implementation can be mapped to write syslog entries into a shared (with Linux) log buffer, so no changes in Linux are needed. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Computers are not intelligent. They only think they are.