public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 6/8] omap_gpmc: BCH8 support (ELM based)
Date: Wed, 21 Nov 2012 12:04:42 -0500	[thread overview]
Message-ID: <20121121170442.GB6794@oliver-linux> (raw)
In-Reply-To: <50A4ED43.5060505@gmail.com>

On Thu, Nov 15, 2012 at 02:25:23PM +0100, Andreas Bie?mann wrote:
> Dear Ilya Yanok,
> 
> On 07.11.2012 00:06, Ilya Yanok wrote:
> > From: Mansoor Ahamed <mansoor.ahamed@ti.com>
> > 
> > This patch adds support for BCH8 error correction code to omap_gpmc
> > driver. We use GPMC to generate codes/syndromes but we need ELM to find
> > error locations from given syndrome.
> > 
> 
> first of all, I wonder why this is so different than the kernel
> implementation for BCH. I mean the API (and content) of this and commit
> 8d602cf50d3bba864bc1438f486b626df69c87b3 mainline linux seems to differ.
> The main question coming to mind is: Is the resulting OOB layout
> compatible then?

I think this has been mostly addressed now, but for clarity:
- We do NOT want to have > 1 layout used per NAND chip unless we must
  (historically we did because we had ROM that couldn't use >1bit ECC).
- We DO want to utilize the HW as this is the only easy way to get a
  match with the BCH constants the ROM uses.
- There are corresponding kernel patches already posted and working
  their way along.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20121121/2929d2b4/attachment.pgp>

  parent reply	other threads:[~2012-11-21 17:04 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-06 23:06 [U-Boot] [PATCH v2 0/8] NAND support for AM33XX Ilya Yanok
2012-11-06 23:06 ` [U-Boot] [PATCH v2 1/8] OMAP: include sys_proto.h from boot-common Ilya Yanok
2012-11-06 23:06 ` [U-Boot] [PATCH v2 2/8] am335x_evm: add nand pinmux definition Ilya Yanok
2012-11-06 23:06 ` [U-Boot] [PATCH v2 3/8] am33xx: NAND support Ilya Yanok
2012-11-08  9:33   ` Peter Korsgaard
2012-11-15 20:21     ` Ilya Yanok
2012-11-15 22:26       ` Peter Korsgaard
2012-11-21 16:59         ` Tom Rini
2012-11-06 23:06 ` [U-Boot] [PATCH v2 4/8] am335x_evm: enable " Ilya Yanok
2012-11-06 23:06 ` [U-Boot] [PATCH v2 5/8] am33xx: add ELM support Ilya Yanok
2012-11-06 23:06 ` [U-Boot] [PATCH v2 6/8] omap_gpmc: BCH8 support (ELM based) Ilya Yanok
2012-11-15 13:25   ` Andreas Bießmann
     [not found]     ` <CAA3CPjX0pHtU6y6kAtzVmdZq-akGAXhKcpkq92BwBJtb0HbRgw@mail.gmail.com>
2012-11-16 10:24       ` Andreas Bießmann
2012-11-16 15:59         ` Peter Korsgaard
2012-11-17 14:10           ` Andreas Bießmann
2012-11-17 19:13             ` Peter Korsgaard
2012-11-21 17:04     ` Tom Rini [this message]
2012-11-21 20:51       ` Andreas Bießmann
2012-11-06 23:06 ` [U-Boot] [PATCH v2 7/8] am33xx_spl_bch: simple SPL nand loader for AM33XX Ilya Yanok
2012-11-06 23:06 ` [U-Boot] [PATCH v2 8/8] am335x_evm: enable SPL NAND support Ilya Yanok
2012-12-10 20:18 ` [U-Boot] [PATCH v2 0/8] NAND support for AM33XX Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121121170442.GB6794@oliver-linux \
    --to=trini@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox