[U-Boot] [PATCH] mx23: Add POWER and CLKCTRL register definitions

Marek Vasut
2012-11-25T03:06:43Z

Dear Otavio Salvador,

> On Sun, Nov 25, 2012 at 12:54 AM, Marek Vasut <marex@denx.de> wrote:
> > Dear Otavio Salvador,
> >
> >> On Sat, Nov 24, 2012 at 10:21 PM, Marek Vasut <marex@denx.de> wrote:
> >> > Add register definitions for the i.MX23 power control block and
> >> > clock control block. These are essential for the basic bootstrap
> >> > of the i.MX23. Also, properly include them in imx-regs.h .
> >> >
> >> > Signed-off-by: Marek Vasut <marex@denx.de>
> >> > Cc: Stefano Babic <sbabic@denx.de>
> >>
> >> Please don't merge it now as this has been already done in my branch
> >> with mx23.
> >
> > I'm attaching a proper diff against your branch. There are multiple wrong
> > and missing bits in your branch. This patch is done by processing the
> > FSL-provided header file and cross-checking with the datasheet.
> >
> > So, this patch is right, yours is wrong. Sorry.
>
> I am not saying mine is perfect, far from it. And we can fix it in the
> branch but please don't push it until we finish mx23 bootstrap.
>
> Let's work in same code, not duplicate work...

I still don't see any argument against applying this patch -- other than the
fact it will break some out-of-tree port.

Best regards,
Marek Vasut