public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] mkconfig: Make CONFIG_SYS_BOARD_NAME default to the configured target name
Date: Sun, 25 Nov 2012 18:43:59 +0100	[thread overview]
Message-ID: <20121125174359.10CAA20105B@gemini.denx.de> (raw)
In-Reply-To: <1353842534.17518.10.camel@home.hno.se>

Dear Henrik Nordstr?m,

In message <1353842534.17518.10.camel@home.hno.se> you wrote:
> This change makes CONFIG_SYS_BOARD_NAME globally available as the configured
> target name, avoiding the need to define manually for boards having multiple
> targets sharing the same board implementation.
> ---
>  include/config_fallbacks.h |    4 ++++
>  mkconfig                   |    1 +
>  2 files changed, 5 insertions(+), 0 deletions(-)
> 
> diff --git a/include/config_fallbacks.h b/include/config_fallbacks.h
> index bfb9680..a1b2b54 100644
> --- a/include/config_fallbacks.h
> +++ b/include/config_fallbacks.h
> @@ -26,4 +26,8 @@
>  #define CONFIG_EXT4_WRITE
>  #endif
>  
> +#ifndef CONFIG_SYS_BOARD_NAME
> +#define CONFIG_SYS_BOARD_NAME CONFIG_SYS_TARGET
> +#endif
> +
>  #endif	/* __CONFIG_FALLBACKS_H */
> diff --git a/mkconfig b/mkconfig
> index 7c9aa74..ddce037 100755
> --- a/mkconfig
> +++ b/mkconfig
> @@ -173,6 +173,7 @@ done
>  echo "#define CONFIG_SYS_ARCH  \"${arch}\""  >> config.h
>  echo "#define CONFIG_SYS_CPU   \"${cpu}\""   >> config.h
>  echo "#define CONFIG_SYS_BOARD \"${board}\"" >> config.h
> +echo "#define CONFIG_SYS_TARGET \"${BOARD_NAME}\"" >> config.h

I don't see what the difference is between CONFIG_SYS_BOARD (which is
the board name) and CONFIG_SYS_BOARD_NAME ?

In any case, documentation for CONFIG_SYS_BOARD_NAME is missing.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Don't hit a man when he's down - kick him; it's easier.

  reply	other threads:[~2012-11-25 17:43 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-25 11:22 [U-Boot] [PATCH 1/2] mkconfig: Make CONFIG_SYS_BOARD_NAME default to the configured target name Henrik Nordström
2012-11-25 17:43 ` Wolfgang Denk [this message]
2012-11-25 17:55   ` Henrik Nordström
2012-11-25 20:01     ` Wolfgang Denk
2012-11-26  8:21       ` Henrik Nordström
2012-11-26  9:32         ` Wolfgang Denk
2012-11-26 21:05           ` Tom Rini
2012-11-26 21:41             ` Henrik Nordström
2012-11-26 21:51               ` Tom Rini
2012-11-26 22:01                 ` Henrik Nordström
2012-11-27 14:53                   ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121125174359.10CAA20105B@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox