From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Sun, 25 Nov 2012 22:47:22 +0100
Subject: [U-Boot] [PATCH 06/22] ARM sunxi: Basic GPIO driver
In-Reply-To: <20121125195043.3780D20105B@gemini.denx.de>
References: <cover.1353842684.git.henrik@henriknordstrom.net>
	<1353843623.17518.17.camel@home.hno.se>
	<20121125195043.3780D20105B@gemini.denx.de>
Message-ID: <201211252247.22297.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Wolfgang Denk,

> Dear Henrik Nordstr?m,
> 
> In message <1353843623.17518.17.camel@home.hno.se> you wrote:
> > GPIO driver for Allwinner sun4i/sun5i family of SoCs
> > 
> > GPIO Pins are named by their symbolic pin names P<g><#>
> > such as PH19 or H19.
> > 
> > Note: This do not perform any validation if the pin is in use
> > for some other I/O function. Use with care.
> 
> SoB missing.
> 
> 
> Um.... are these patches actually bisectable???  It appears not; for
> example, you reference gpio_direction_input() in ealier patches, but
> define it only now.
> 
> This patch series need a full rework.

It needs a bit of polishing ;-)

Best regards,
Marek Vasut