From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V3 3/4] lcd: calculate line_length after lcd_ctrl_init()
Date: Mon, 26 Nov 2012 22:43:19 +0100 [thread overview]
Message-ID: <20121126224319.49bb27b9@lilith> (raw)
In-Reply-To: <20121109091721.3cb445ec@wker>
Hi Stephen,
On Fri, 9 Nov 2012 09:17:21 +0100, Anatolij Gustschin <agust@denx.de>
wrote:
> On Wed, 7 Nov 2012 23:38:32 -0700
> Stephen Warren <swarren@wwwdotorg.org> wrote:
>
> > When an LCD driver is actually driving a regular external display, e.g.
> > an HDMI monitor, the display resolution might not be known until the
> > display controller has initialized, i.e. during lcd_ctrl_init(). However,
> > lcd.c calculates lcd_line_length before calling this function, thus
> > relying on a hard-coded resolution in struct panel_info.
> >
> > Instead, defer this calculation until after lcd_ctrl_init() has had the
> > chance to dynamically determine the resolution. This needs to happen
> > before lcd_clear(), since the value is used there.
> >
> > grep indicates that no code outside lcd.c uses this lcd_line_length; in
> > particular, no lcd_ctrl_init() implementations read it.
> >
> > Signed-off-by: Stephen Warren <swarren@wwwdotorg.org>
> > --
> > v3: No change.
> > ---
> > common/lcd.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
>
> Acked-by: Anatolij Gustschin <agust@denx.de>
Sorry, but this one does not apply cleanly any more. Can you fix it, and
make sure 4/4 also applies on u-boot-arm/master? I'll apply all four
patches then.
Amicalement,
--
Albert.
next prev parent reply other threads:[~2012-11-26 21:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-08 6:38 [U-Boot] [PATCH V3 1/4] ARM: bcm2835: add mailbox driver Stephen Warren
2012-11-08 6:38 ` [U-Boot] [PATCH V3 2/4] ARM: rpi_b: use bcm2835 mbox driver to get memory size Stephen Warren
2012-11-08 6:38 ` [U-Boot] [PATCH V3 3/4] lcd: calculate line_length after lcd_ctrl_init() Stephen Warren
2012-11-09 8:17 ` Anatolij Gustschin
2012-11-26 21:43 ` Albert ARIBAUD [this message]
2012-11-08 6:38 ` [U-Boot] [PATCH V3 4/4] video: add a driver for the bcm2835 Stephen Warren
2012-11-09 8:24 ` Anatolij Gustschin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121126224319.49bb27b9@lilith \
--to=albert.u.boot@aribaud.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox