From mboxrd@z Thu Jan 1 00:00:00 1970 From: Albert ARIBAUD Date: Mon, 26 Nov 2012 22:43:19 +0100 Subject: [U-Boot] [PATCH V3 3/4] lcd: calculate line_length after lcd_ctrl_init() In-Reply-To: <20121109091721.3cb445ec@wker> References: <1352356713-11538-1-git-send-email-swarren@wwwdotorg.org> <1352356713-11538-3-git-send-email-swarren@wwwdotorg.org> <20121109091721.3cb445ec@wker> Message-ID: <20121126224319.49bb27b9@lilith> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Stephen, On Fri, 9 Nov 2012 09:17:21 +0100, Anatolij Gustschin wrote: > On Wed, 7 Nov 2012 23:38:32 -0700 > Stephen Warren wrote: > > > When an LCD driver is actually driving a regular external display, e.g. > > an HDMI monitor, the display resolution might not be known until the > > display controller has initialized, i.e. during lcd_ctrl_init(). However, > > lcd.c calculates lcd_line_length before calling this function, thus > > relying on a hard-coded resolution in struct panel_info. > > > > Instead, defer this calculation until after lcd_ctrl_init() has had the > > chance to dynamically determine the resolution. This needs to happen > > before lcd_clear(), since the value is used there. > > > > grep indicates that no code outside lcd.c uses this lcd_line_length; in > > particular, no lcd_ctrl_init() implementations read it. > > > > Signed-off-by: Stephen Warren > > -- > > v3: No change. > > --- > > common/lcd.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > Acked-by: Anatolij Gustschin Sorry, but this one does not apply cleanly any more. Can you fix it, and make sure 4/4 also applies on u-boot-arm/master? I'll apply all four patches then. Amicalement, -- Albert.